Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: content/browser/shared_worker/shared_worker_service_impl.h

Issue 2286003002: Reland of Check that all shared workers are terminated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_
6 #define CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_ 6 #define CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 void OnSharedWorkerMessageFilterClosing( 86 void OnSharedWorkerMessageFilterClosing(
87 SharedWorkerMessageFilter* filter); 87 SharedWorkerMessageFilter* filter);
88 88
89 // Checks the worker dependency of renderer processes and calls 89 // Checks the worker dependency of renderer processes and calls
90 // IncrementWorkerRefCount and DecrementWorkerRefCount of 90 // IncrementWorkerRefCount and DecrementWorkerRefCount of
91 // RenderProcessHostImpl on UI thread if necessary. 91 // RenderProcessHostImpl on UI thread if necessary.
92 void CheckWorkerDependency(); 92 void CheckWorkerDependency();
93 93
94 void NotifyWorkerDestroyed(int worker_process_id, int worker_route_id); 94 void NotifyWorkerDestroyed(int worker_process_id, int worker_route_id);
95 95
96 // TODO(alokp): Remove after collecting crash data.
97 // Temporary checks to verify that all shared workers are terminated.
98 // It is suspected that shared workers prevent render process hosts
99 // from shutting down: crbug.com/608049
100 void CheckAllWorkersTerminated();
101
96 private: 102 private:
97 class SharedWorkerPendingInstance; 103 class SharedWorkerPendingInstance;
98 class SharedWorkerReserver; 104 class SharedWorkerReserver;
99 105
100 friend struct base::DefaultSingletonTraits<SharedWorkerServiceImpl>; 106 friend struct base::DefaultSingletonTraits<SharedWorkerServiceImpl>;
101 friend class SharedWorkerServiceImplTest; 107 friend class SharedWorkerServiceImplTest;
102 108
103 using UpdateWorkerDependencyFunc = void (*)(const std::vector<int>&, 109 using UpdateWorkerDependencyFunc = void (*)(const std::vector<int>&,
104 const std::vector<int>&); 110 const std::vector<int>&);
105 using TryIncrementWorkerRefCountFunc = bool (*)(bool); 111 using TryIncrementWorkerRefCountFunc = bool (*)(bool);
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 int next_pending_instance_id_; 175 int next_pending_instance_id_;
170 176
171 base::ObserverList<WorkerServiceObserver> observers_; 177 base::ObserverList<WorkerServiceObserver> observers_;
172 178
173 DISALLOW_COPY_AND_ASSIGN(SharedWorkerServiceImpl); 179 DISALLOW_COPY_AND_ASSIGN(SharedWorkerServiceImpl);
174 }; 180 };
175 181
176 } // namespace content 182 } // namespace content
177 183
178 #endif // CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_ 184 #endif // CONTENT_BROWSER_SHARED_WORKER_SHARED_WORKER_SERVICE_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/shared_worker/shared_worker_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698