content/browser/shared_worker/shared_worker_service_impl.h - Issue 2286003002: Reland of Check that all shared workers are terminated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/shared_worker/shared_worker_service_impl.h

Issue 2286003002: Reland of Check that all shared workers are terminated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/shared_worker/shared_worker_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/shared_worker/shared_worker_service_impl.h

diff --git a/content/browser/shared_worker/shared_worker_service_impl.h b/content/browser/shared_worker/shared_worker_service_impl.h

index 3c36f638e0afac12b9fbee246dab56f125da5f49..322817431add2eb001e392163f2795a10bd51b11 100644

--- a/content/browser/shared_worker/shared_worker_service_impl.h

+++ b/content/browser/shared_worker/shared_worker_service_impl.h

@@ -93,6 +93,12 @@

void NotifyWorkerDestroyed(int worker_process_id, int worker_route_id);

+ // TODO(alokp): Remove after collecting crash data.

+ // Temporary checks to verify that all shared workers are terminated.

+ // It is suspected that shared workers prevent render process hosts

+ // from shutting down: crbug.com/608049

+ void CheckAllWorkersTerminated();

private:

class SharedWorkerPendingInstance;

class SharedWorkerReserver;