Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/test/chromedriver/chrome/automation_extension.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/javascript_browser_test.cc ('k') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/automation_extension.cc
diff --git a/chrome/test/chromedriver/chrome/automation_extension.cc b/chrome/test/chromedriver/chrome/automation_extension.cc
index 13925af9314d07f46ed9a7bb005bd04428420881..01e31871cbf1fe64ba5b3952fd10e70c6d7b291d 100644
--- a/chrome/test/chromedriver/chrome/automation_extension.cc
+++ b/chrome/test/chromedriver/chrome/automation_extension.cc
@@ -100,7 +100,7 @@ Status AutomationExtension::GetWindowInfo(int* x,
Status AutomationExtension::UpdateWindow(
const base::DictionaryValue& update_info) {
base::ListValue args;
- args.Append(update_info.DeepCopy());
+ args.Append(update_info.CreateDeepCopy());
std::unique_ptr<base::Value> result;
return web_view_->CallAsyncFunction(std::string(),
"updateWindow",
« no previous file with comments | « chrome/test/base/javascript_browser_test.cc ('k') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698