Fix problem that caused anonymous mixin applications to be named "null".

Fix problem that caused anonymous mixin applications to be named "null".

BUG=http://dartbug.com/12464
R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27073

[ngeoffray, 2013-08-16 07:28:34]

LGTM

https://codereview.chromium.org/22859016/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/22859016/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1989:
String reflectionName = getReflectionName(classElement, className);
The previous version read better. Could you have a higher abstraction than just
doing a null check?

[ahe, 2013-08-16 08:32:29]

Thank you, Nicolas!

https://codereview.chromium.org/22859016/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/22859016/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1989:
String reflectionName = getReflectionName(classElement, className);
On 2013/08/16 07:28:34, ngeoffray wrote:
> The previous version read better. Could you have a higher abstraction than
just
> doing a null check?

Not sure. The problem is that I might also cache stuff in getReflection name, so
even if the backend tells us to retain the name, getReflection might return
null.

For example, I only need to record once that toString$0 is toString:0:0.

Also, you can see getReflectionName is now used consistently throughout the
emitter. 

Cheers,
Peter

[ahe, 2013-09-03 18:35:13]

Committed patchset #1 manually as r27073 (presubmit successful).