Fix problem that caused anonymous mixin applications to be named "null".

dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 /**
  * A function element that represents a closure call. The signature is copied
  * from the given element.
  */
@@ skipping 1968 matching lines @@
     if (hasStatics) {
       builder.addProperty('static', new jsAst.Blob(statics));
     }
 
     // TODO(ahe): This method (generateClass) should return a jsAst.Expression.
     if (!buffer.isEmpty) {
       buffer.write(',$n$n');
     }
     buffer.write('$className:$_');
     buffer.write(jsAst.prettyPrint(builder.toObjectInitializer(), compiler));
-    if (backend.shouldRetainName(classElement.name)) {
-      String reflectionName = getReflectionName(classElement, className);
+    String reflectionName = getReflectionName(classElement, className);

[ngeoffray, 2013/08/16 07:28:34]

The previous version read better. Could you have a higher abstraction than just
doing a null check?

[ahe, 2013/08/16 08:32:29]

Not sure. The problem is that I might also cache stuff in getReflection name, so
even if the backend tells us to retain the name, getReflection might return
null.

For example, I only need to record once that toString$0 is toString:0:0.

Also, you can see getReflectionName is now used consistently throughout the
emitter. 

Cheers,
Peter

+    if (reflectionName != null) {
       List<int> interfaces = <int>[];
       for (DartType interface in classElement.interfaces) {
         interfaces.add(reifyType(interface));
       }
       buffer.write(',$n$n"+$reflectionName": $interfaces');
     }
   }
 
   bool get getterAndSetterCanBeImplementedByFieldSpec => true;
 
@@ skipping 2088 matching lines @@
 
 const String HOOKS_API_USAGE = """
 // The code supports the following hooks:
 // dartPrint(message)   - if this function is defined it is called
 //                        instead of the Dart [print] method.
 // dartMainRunner(main) - if this function is defined, the Dart [main]
 //                        method will not be invoked directly.
 //                        Instead, a closure that will invoke [main] is
 //                        passed to [dartMainRunner].
 """;