Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 22859016: Fix problem that caused anonymous mixin applications to be named "null". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/tests/lib/mirrors/mixin_members_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
index 5c52a80282486c2729c99232a23d9b20f13c3851..609e97f7a4b07e8decfa9e7da8b72f8c3bf602d1 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
@@ -1986,8 +1986,8 @@ class CodeEmitterTask extends CompilerTask {
}
buffer.write('$className:$_');
buffer.write(jsAst.prettyPrint(builder.toObjectInitializer(), compiler));
- if (backend.shouldRetainName(classElement.name)) {
- String reflectionName = getReflectionName(classElement, className);
+ String reflectionName = getReflectionName(classElement, className);
ngeoffray 2013/08/16 07:28:34 The previous version read better. Could you have a
ahe 2013/08/16 08:32:29 Not sure. The problem is that I might also cache s
+ if (reflectionName != null) {
List<int> interfaces = <int>[];
for (DartType interface in classElement.interfaces) {
interfaces.add(reifyType(interface));
« no previous file with comments | « no previous file | dart/tests/lib/mirrors/mixin_members_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698