Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2285493002: Change the tracking request sent by NetErrorHelper from FrameTypeTopLevel to FrameTypeNone. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
Reviewers:
clamy, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the tracking request sent by NetErrorHelper from FrameTypeTopLevel to FrameTypeNone. FrameTypeTopLevel in this case will be considered bad message by PlzNavigate. This fixes browser tests with PlzNavigate: ErrorPageTest.DNSError_DoClickLink ErrorPageTest.DNSError_DoReload ErrorPageTest.DNSError_DoReloadAfterSamePageNavigation ErrorPageTest.DNSError_DoSearch ErrorPageTest.StaleCacheStatus BUG=576285 Committed: https://crrev.com/b7e811c5e05e34e087b2e54f36e80ac438dd4936 Cr-Commit-Position: refs/heads/master@{#414660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/renderer/net/net_error_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter View 1 chunk +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
yzshen1
Hi, Matt and Camille. Please take a look. Thanks!
4 years, 3 months ago (2016-08-25 22:16:05 UTC) #2
mmenke
On 2016/08/25 22:16:05, yzshen1 wrote: > Hi, Matt and Camille. > > Please take a ...
4 years, 3 months ago (2016-08-25 22:24:31 UTC) #5
clamy
Thanks! Lgtm
4 years, 3 months ago (2016-08-25 22:28:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285493002/1
4 years, 3 months ago (2016-08-25 23:41:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/130411)
4 years, 3 months ago (2016-08-26 00:56:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285493002/1
4 years, 3 months ago (2016-08-26 05:44:08 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 06:34:24 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 06:37:40 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7e811c5e05e34e087b2e54f36e80ac438dd4936
Cr-Commit-Position: refs/heads/master@{#414660}

Powered by Google App Engine
This is Rietveld 408576698