Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2309083002: PlzNavigate: Fix history navigation for error pages. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
Reviewers:
clamy
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Fix history navigation for error pages. Previously, the handler of FrameMsg_FailedNavigation didn't check whether the navigation was a history navigation or not, and always treated it as a new navigation. This fixes browser tests with PlzNavigate: ErrorPageAutoReloadTest.AutoReload ErrorPageAutoReloadTest.IgnoresSamePageNavigation ErrorPageAutoReloadTest.ManualReloadNotSuppressed ErrorPageTest.DNSError_GoBack2 ErrorPageTest.DNSError_GoBack2AndForward ErrorPageTest.DNSError_GoBack2Forward2 BUG=576285 Committed: https://crrev.com/0424e695ecd048c6abbd58501f732fb91aee2e23 Cr-Commit-Position: refs/heads/master@{#416647}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M content/renderer/render_frame_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 4 chunks +19 lines, -8 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (11 generated)
yzshen1
Hi, Camille. Would you please take a look? Thanks!
4 years, 3 months ago (2016-09-04 08:18:07 UTC) #6
clamy
Thanks! Lgtm.
4 years, 3 months ago (2016-09-06 11:54:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309083002/20001
4 years, 3 months ago (2016-09-06 15:19:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/64234)
4 years, 3 months ago (2016-09-06 16:02:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309083002/20001
4 years, 3 months ago (2016-09-06 16:37:13 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 16:49:17 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 16:50:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0424e695ecd048c6abbd58501f732fb91aee2e23
Cr-Commit-Position: refs/heads/master@{#416647}

Powered by Google App Engine
This is Rietveld 408576698