Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: chrome/renderer/net/net_error_helper.cc

Issue 2285493002: Change the tracking request sent by NetErrorHelper from FrameTypeTopLevel to FrameTypeNone. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/net/net_error_helper.h" 5 #include "chrome/renderer/net/net_error_helper.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 const std::string& tracking_request_body) { 290 const std::string& tracking_request_body) {
291 // If there's already a pending tracking request, this will cancel it. 291 // If there's already a pending tracking request, this will cancel it.
292 tracking_fetcher_.reset(content::ResourceFetcher::Create(tracking_url)); 292 tracking_fetcher_.reset(content::ResourceFetcher::Create(tracking_url));
293 tracking_fetcher_->SetMethod("POST"); 293 tracking_fetcher_->SetMethod("POST");
294 tracking_fetcher_->SetBody(tracking_request_body); 294 tracking_fetcher_->SetBody(tracking_request_body);
295 tracking_fetcher_->SetHeader("Content-Type", "application/json"); 295 tracking_fetcher_->SetHeader("Content-Type", "application/json");
296 296
297 tracking_fetcher_->Start( 297 tracking_fetcher_->Start(
298 render_frame()->GetWebFrame(), 298 render_frame()->GetWebFrame(),
299 blink::WebURLRequest::RequestContextInternal, 299 blink::WebURLRequest::RequestContextInternal,
300 blink::WebURLRequest::FrameTypeTopLevel, 300 blink::WebURLRequest::FrameTypeNone,
301 content::ResourceFetcher::PLATFORM_LOADER, 301 content::ResourceFetcher::PLATFORM_LOADER,
302 base::Bind(&NetErrorHelper::OnTrackingRequestComplete, 302 base::Bind(&NetErrorHelper::OnTrackingRequestComplete,
303 base::Unretained(this))); 303 base::Unretained(this)));
304 } 304 }
305 305
306 void NetErrorHelper::ReloadPage(bool bypass_cache) { 306 void NetErrorHelper::ReloadPage(bool bypass_cache) {
307 render_frame()->GetWebFrame()->reload( 307 render_frame()->GetWebFrame()->reload(
308 bypass_cache ? blink::WebFrameLoadType::ReloadBypassingCache 308 bypass_cache ? blink::WebFrameLoadType::ReloadBypassingCache
309 : blink::WebFrameLoadType::Reload); 309 : blink::WebFrameLoadType::Reload);
310 } 310 }
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 const blink::WebURLResponse& response, 373 const blink::WebURLResponse& response,
374 const std::string& data) { 374 const std::string& data) {
375 tracking_fetcher_.reset(); 375 tracking_fetcher_.reset();
376 } 376 }
377 377
378 #if defined(OS_ANDROID) 378 #if defined(OS_ANDROID)
379 void NetErrorHelper::OnSetHasOfflinePages(bool has_offline_pages) { 379 void NetErrorHelper::OnSetHasOfflinePages(bool has_offline_pages) {
380 core_->OnSetHasOfflinePages(has_offline_pages); 380 core_->OnSetHasOfflinePages(has_offline_pages);
381 } 381 }
382 #endif // defined(OS_ANDROID) 382 #endif // defined(OS_ANDROID)
OLDNEW
« no previous file with comments | « no previous file | testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698