Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2285083003:
[Chromecast] Suppress lint warnings for Chromecast Android build. (Closed)
Description[Chromecast] Suppress lint warnings for Chromecast Android build.
Recently, lint wanrnings were made fatal for Android builds:
https://codereview.chromium.org/2241233002
A number of internal files for the Chromecast Android build have lint
errors, breaking the build at compile time. b/31140436 has been assigned
to clean up these files. In the meantime, we need to supress these
errors without leaking internal details about Cast code. Use the
following regexes where necessary to suppress errors:
* "chromecast/internal"
* "com/android/tv"
* "com/google/android/apps/cast"
* "com/google/android/apps/mediashell"
The changes introduced in this CL will be reverted as they are
cleaned up.
BUG= internal b/31140436
Committed: https://crrev.com/3dfdc0225cb9d555e205ded146280f4260fcf8b3
Cr-Commit-Position: refs/heads/master@{#415188}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Formatting fixes #Messages
Total messages: 22 (14 generated)
slan@chromium.org changed reviewers: + estevenson@chromium.org, mikecase@chromium.org, sanfin@chromium.org
Hey all, Chromecast has a substantial amount of internal code that has not been kept lint-tidy, which means that our master branch is now broken. This is NOT a long term patch, just a way of building this code against master while we clean these files up this week. This is a high-priority effort for sanfin@; you can follow along here: b/31140436. This seems like the most prudent way to keep us building. An alternative would be to introduce non-fatal lint behavior as a GN arg, but I would prefer this solution if possible. PTAL, thank you!
Description was changed from ========== [Chromecast] Suppress lint warnings for Chromecast Android build. Recently, lint wanrnings were made fatal for Android builds: https://codereview.chromium.org/2241233002 A number of internal files for the Chromecast Android build have lint errors, breaking the build at compile time. b/31140436 has been assigned to clean up these files. In the meantime, we need to supress these errors without leaking internal details about Cast code. Use the following regexes where necessary to suppress errors: * "chromecast/internal" * "com/android/tv" * "com/google/android/apps/cast" * "com/google/android/apps/mediashell" The changes introduced in this change will be reverted as they are cleaned up. BUG= internal b/31140436 ========== to ========== [Chromecast] Suppress lint warnings for Chromecast Android build. Recently, lint wanrnings were made fatal for Android builds: https://codereview.chromium.org/2241233002 A number of internal files for the Chromecast Android build have lint errors, breaking the build at compile time. b/31140436 has been assigned to clean up these files. In the meantime, we need to supress these errors without leaking internal details about Cast code. Use the following regexes where necessary to suppress errors: * "chromecast/internal" * "com/android/tv" * "com/google/android/apps/cast" * "com/google/android/apps/mediashell" The changes introduced in this CL will be reverted as they are cleaned up. BUG= internal b/31140436 ==========
The CQ bit was checked by slan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
l-g-t-m w/nits (don't think I'm supposed to approve CLs yet since I'm not a Chromium committer) https://codereview.chromium.org/2285083003/diff/1/build/android/lint/suppress... File build/android/lint/suppressions.xml (right): https://codereview.chromium.org/2285083003/diff/1/build/android/lint/suppress... build/android/lint/suppressions.xml:100: <issue id="IconDuplicates" severity="Error"> nit: unindent https://codereview.chromium.org/2285083003/diff/1/build/android/lint/suppress... build/android/lint/suppressions.xml:288: <ignore regexp="chromecast/internal" /> nit: unindent
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Formatting comments resolved. Guessing that the telemetry failures were a flake. Rerunning. https://codereview.chromium.org/2285083003/diff/1/build/android/lint/suppress... File build/android/lint/suppressions.xml (right): https://codereview.chromium.org/2285083003/diff/1/build/android/lint/suppress... build/android/lint/suppressions.xml:100: <issue id="IconDuplicates" severity="Error"> On 2016/08/29 04:21:39, estevenson wrote: > nit: unindent Done. https://codereview.chromium.org/2285083003/diff/1/build/android/lint/suppress... build/android/lint/suppressions.xml:288: <ignore regexp="chromecast/internal" /> On 2016/08/29 04:21:39, estevenson wrote: > nit: unindent Done.
The CQ bit was checked by slan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
This lgtm. Just remember to revert these changes once the lint errors are fixed :D
The CQ bit was checked by slan@chromium.org
slan@chromium.org changed reviewers: + tsunghung@chromium.org
+tsunghung for FYI
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] Suppress lint warnings for Chromecast Android build. Recently, lint wanrnings were made fatal for Android builds: https://codereview.chromium.org/2241233002 A number of internal files for the Chromecast Android build have lint errors, breaking the build at compile time. b/31140436 has been assigned to clean up these files. In the meantime, we need to supress these errors without leaking internal details about Cast code. Use the following regexes where necessary to suppress errors: * "chromecast/internal" * "com/android/tv" * "com/google/android/apps/cast" * "com/google/android/apps/mediashell" The changes introduced in this CL will be reverted as they are cleaned up. BUG= internal b/31140436 ========== to ========== [Chromecast] Suppress lint warnings for Chromecast Android build. Recently, lint wanrnings were made fatal for Android builds: https://codereview.chromium.org/2241233002 A number of internal files for the Chromecast Android build have lint errors, breaking the build at compile time. b/31140436 has been assigned to clean up these files. In the meantime, we need to supress these errors without leaking internal details about Cast code. Use the following regexes where necessary to suppress errors: * "chromecast/internal" * "com/android/tv" * "com/google/android/apps/cast" * "com/google/android/apps/mediashell" The changes introduced in this CL will be reverted as they are cleaned up. BUG= internal b/31140436 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] Suppress lint warnings for Chromecast Android build. Recently, lint wanrnings were made fatal for Android builds: https://codereview.chromium.org/2241233002 A number of internal files for the Chromecast Android build have lint errors, breaking the build at compile time. b/31140436 has been assigned to clean up these files. In the meantime, we need to supress these errors without leaking internal details about Cast code. Use the following regexes where necessary to suppress errors: * "chromecast/internal" * "com/android/tv" * "com/google/android/apps/cast" * "com/google/android/apps/mediashell" The changes introduced in this CL will be reverted as they are cleaned up. BUG= internal b/31140436 ========== to ========== [Chromecast] Suppress lint warnings for Chromecast Android build. Recently, lint wanrnings were made fatal for Android builds: https://codereview.chromium.org/2241233002 A number of internal files for the Chromecast Android build have lint errors, breaking the build at compile time. b/31140436 has been assigned to clean up these files. In the meantime, we need to supress these errors without leaking internal details about Cast code. Use the following regexes where necessary to suppress errors: * "chromecast/internal" * "com/android/tv" * "com/google/android/apps/cast" * "com/google/android/apps/mediashell" The changes introduced in this CL will be reverted as they are cleaned up. BUG= internal b/31140436 Committed: https://crrev.com/3dfdc0225cb9d555e205ded146280f4260fcf8b3 Cr-Commit-Position: refs/heads/master@{#415188} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3dfdc0225cb9d555e205ded146280f4260fcf8b3 Cr-Commit-Position: refs/heads/master@{#415188} |
