Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <lint> | 2 <lint> |
| 3 <!-- | 3 <!-- |
| 4 STOP! It looks like you want to suppress some lint errors: | 4 STOP! It looks like you want to suppress some lint errors: |
| 5 - Have you tried identifing the offending patch? | 5 - Have you tried identifing the offending patch? |
| 6 Ask the author for a fix and/or revert the patch. | 6 Ask the author for a fix and/or revert the patch. |
| 7 - It is preferred to add suppressions in the code instead of | 7 - It is preferred to add suppressions in the code instead of |
| 8 sweeping it under the rug here. See: | 8 sweeping it under the rug here. See: |
| 9 | 9 |
| 10 http://developer.android.com/tools/debugging/improving-w-lint.html | 10 http://developer.android.com/tools/debugging/improving-w-lint.html |
| (...skipping 19 matching lines...) Expand all Loading... | |
| 30 </issue> | 30 </issue> |
| 31 <issue id="ButtonStyle" severity="Error"> | 31 <issue id="ButtonStyle" severity="Error"> |
| 32 <ignore regexp="remoting/android/host/res/layout/main.xml" /> | 32 <ignore regexp="remoting/android/host/res/layout/main.xml" /> |
| 33 </issue> | 33 </issue> |
| 34 <issue id="CommitPrefEdits"> | 34 <issue id="CommitPrefEdits"> |
| 35 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali dation/ticl/android2/channel/AndroidChannelPreferences.java" /> | 35 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali dation/ticl/android2/channel/AndroidChannelPreferences.java" /> |
| 36 </issue> | 36 </issue> |
| 37 <issue id="ContentDescription" severity="Error"> | 37 <issue id="ContentDescription" severity="Error"> |
| 38 <ignore regexp="blimp/client/app/android/java/res/layout/blimp_main.xml" /> | 38 <ignore regexp="blimp/client/app/android/java/res/layout/blimp_main.xml" /> |
| 39 <ignore regexp="chrome/android/java/res/layout/download_content.xml" /> | 39 <ignore regexp="chrome/android/java/res/layout/download_content.xml" /> |
| 40 <ignore regexp="chromecast/internal" /> | |
| 40 </issue> | 41 </issue> |
| 41 <issue id="DefaultLocale"> | 42 <issue id="DefaultLocale"> |
| 42 <ignore regexp="clank" /> | 43 <ignore regexp="clank" /> |
| 44 <ignore regexp="com/android/tv" /> | |
| 43 <ignore regexp="org/chromium/chrome/browser/payments/PaymentRequestMetricsTe st.class" /> | 45 <ignore regexp="org/chromium/chrome/browser/payments/PaymentRequestMetricsTe st.class" /> |
| 44 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbChooserPr eferences" /> | 46 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbChooserPr eferences" /> |
| 45 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbDevicePre ferences" /> | 47 <ignore regexp="org/chromium/chrome/browser/preferences/website/UsbDevicePre ferences" /> |
| 46 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali dation/external/client/contrib/AndroidListenerState.java" /> | 48 <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invali dation/external/client/contrib/AndroidListenerState.java" /> |
| 47 </issue> | 49 </issue> |
| 48 <issue id="DrawAllocation"> | 50 <issue id="DrawAllocation"> |
| 49 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ContentViewRenderView.java" /> | 51 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ContentViewRenderView.java" /> |
| 50 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /PopupZoomer.java" /> | 52 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /PopupZoomer.java" /> |
| 51 </issue> | 53 </issue> |
| 52 <issue id="ExportedContentProvider"> | 54 <issue id="ExportedContentProvider"> |
| 53 <ignore path="AndroidManifest.xml" /> | 55 <ignore path="AndroidManifest.xml" /> |
| 54 </issue> | 56 </issue> |
| 55 <issue id="ExportedService" severity="Error"> | 57 <issue id="ExportedService" severity="Error"> |
| 56 <ignore regexp="AndroidManifest.xml" /> | 58 <ignore regexp="AndroidManifest.xml" /> |
| 57 </issue> | 59 </issue> |
| 58 <issue id="HandlerLeak"> | 60 <issue id="HandlerLeak"> |
| 59 <ignore regexp="android_webview/glue/java/src/com/android/webview/chromium/W ebViewContentsClientAdapter.java" /> | 61 <ignore regexp="android_webview/glue/java/src/com/android/webview/chromium/W ebViewContentsClientAdapter.java" /> |
| 60 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/composit or/overlays/strip/StripLayoutHelper.java" /> | 62 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/composit or/overlays/strip/StripLayoutHelper.java" /> |
| 61 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAS erviceClient.java" /> | 63 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAS erviceClient.java" /> |
| 62 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/tab/Tab. java" /> | 64 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/tab/Tab. java" /> |
| 65 <ignore regexp="chromecast/internal" /> | |
| 63 <ignore regexp="remoting/android/java/src/org/chromium/chromoting/TapGesture Detector.java" /> | 66 <ignore regexp="remoting/android/java/src/org/chromium/chromoting/TapGesture Detector.java" /> |
| 64 </issue> | 67 </issue> |
| 65 <issue id="HardcodedDebugMode" severity="Fatal"> | 68 <issue id="HardcodedDebugMode" severity="Fatal"> |
| 66 <ignore path="AndroidManifest.xml" /> | 69 <ignore path="AndroidManifest.xml" /> |
| 67 </issue> | 70 </issue> |
| 68 <issue id="HardcodedText" severity="Error"> | 71 <issue id="HardcodedText" severity="Error"> |
| 72 <ignore regexp="chromecast/internal" /> | |
| 69 <ignore regexp="remoting/android/host/res/layout/main.xml" /> | 73 <ignore regexp="remoting/android/host/res/layout/main.xml" /> |
| 70 </issue> | 74 </issue> |
| 71 <issue id="IconColors" severity="Error"> | 75 <issue id="IconColors" severity="Error"> |
| 72 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-hdpi/not ification_icon.png" /> | 76 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-hdpi/not ification_icon.png" /> |
| 73 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-mdpi/not ification_icon.png" /> | 77 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-mdpi/not ification_icon.png" /> |
| 74 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xhdpi/no tification_icon.png" /> | 78 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xhdpi/no tification_icon.png" /> |
| 75 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxhdpi/n otification_icon.png" /> | 79 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxhdpi/n otification_icon.png" /> |
| 76 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxxhdpi/ notification_icon.png" /> | 80 <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxxhdpi/ notification_icon.png" /> |
| 77 </issue> | 81 </issue> |
| 78 <issue id="IconDensities"> | 82 <issue id="IconDensities"> |
| 79 <!-- crbug.com/457918 is tracking missing assets --> | 83 <!-- crbug.com/457918 is tracking missing assets --> |
| 80 <ignore regexp="chrome/android/java/res/drawable-xxhdpi" /> | 84 <ignore regexp="chrome/android/java/res/drawable-xxhdpi" /> |
| 81 <ignore regexp="chrome/android/java/res/drawable-xxxhdpi" /> | 85 <ignore regexp="chrome/android/java/res/drawable-xxxhdpi" /> |
| 86 <ignore regexp="chromecast/internal" /> | |
| 82 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxhdpi" /> | 87 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxhdpi" /> |
| 83 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxxhdpi" /> | 88 <ignore regexp="components/web_contents_delegate_android/android/java/res/dr awable-xxxhdpi" /> |
| 84 <ignore regexp="content/public/android/java/res/drawable-xxhdpi" /> | 89 <ignore regexp="content/public/android/java/res/drawable-xxhdpi" /> |
| 85 <ignore regexp="content/public/android/java/res/drawable-xxxhdpi" /> | 90 <ignore regexp="content/public/android/java/res/drawable-xxxhdpi" /> |
| 86 <ignore regexp="ui/android/java/res/drawable-xxhdpi" /> | 91 <ignore regexp="ui/android/java/res/drawable-xxhdpi" /> |
| 87 <ignore regexp="ui/android/java/res/drawable-xxxhdpi" /> | 92 <ignore regexp="ui/android/java/res/drawable-xxxhdpi" /> |
| 88 <!-- The large assets below only include a few densities to reduce APK size. --> | 93 <!-- The large assets below only include a few densities to reduce APK size. --> |
| 89 <ignore regexp=": data_reduction_illustration.png, google_icon_sprite.png, p hysical_web_logo.png, physical_web_logo_anim1.png, physical_web_logo_anim2.png$" /> | 94 <ignore regexp=": data_reduction_illustration.png, google_icon_sprite.png, p hysical_web_logo.png, physical_web_logo_anim1.png, physical_web_logo_anim2.png$" /> |
| 90 </issue> | 95 </issue> |
| 91 <issue id="IconDipSize"> | 96 <issue id="IconDipSize"> |
| 97 <ignore regexp="chromecast/internal" /> | |
| 92 <ignore regexp="google_icon_sprite.png.*" /> | 98 <ignore regexp="google_icon_sprite.png.*" /> |
| 93 </issue> | 99 </issue> |
| 100 <issue id="IconDuplicates" severity="Error"> | |
|
estevenson
2016/08/29 04:21:39
nit: unindent
slan
2016/08/29 14:01:34
Done.
| |
| 101 <ignore regexp="chromecast/internal" /> | |
| 102 </issue> | |
| 103 <issue id="IconDuplicatesConfig" severity="Error"> | |
| 104 <ignore regexp="chromecast/internal" /> | |
| 105 </issue> | |
| 106 <issue id="IconLauncherShape" severity="Error"> | |
| 107 <ignore regexp="chromecast/internal" /> | |
| 108 </issue> | |
| 94 <issue id="IconLocation"> | 109 <issue id="IconLocation"> |
| 110 <ignore regexp="chromecast/internal" /> | |
| 95 <!-- It is OK for content_shell_apk to have missing assets. --> | 111 <!-- It is OK for content_shell_apk to have missing assets. --> |
| 96 <ignore regexp="content/shell/android/java/res/" /> | 112 <ignore regexp="content/shell/android/java/res/" /> |
| 97 <!-- TODO(lambroslambrou) remove this once crbug.com/502030 is fixed. --> | 113 <!-- TODO(lambroslambrou) remove this once crbug.com/502030 is fixed. --> |
| 98 <ignore regexp="remoting/android/java/res" /> | 114 <ignore regexp="remoting/android/java/res" /> |
| 99 <!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/dr awable/icon.png --> | 115 <!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/dr awable/icon.png --> |
| 100 <ignore regexp="res/drawable/icon.png" /> | 116 <ignore regexp="res/drawable/icon.png" /> |
| 101 </issue> | 117 </issue> |
| 102 <issue id="IconMissingDensityFolder"> | 118 <issue id="IconMissingDensityFolder"> |
| 103 <!-- see crbug.com/542435 --> | 119 <!-- see crbug.com/542435 --> |
| 104 <ignore regexp="android_webview/apk/java/res" /> | 120 <ignore regexp="android_webview/apk/java/res" /> |
| 105 <ignore regexp="android_webview/tools/system_webview_shell/apk/res" /> | 121 <ignore regexp="android_webview/tools/system_webview_shell/apk/res" /> |
| 106 <ignore regexp="chrome/android/webapk/shell_apk/res" /> | 122 <ignore regexp="chrome/android/webapk/shell_apk/res" /> |
| 123 <ignore regexp="chromecast/internal" /> | |
| 107 <ignore regexp="tools/android/push_apps_to_background/res" /> | 124 <ignore regexp="tools/android/push_apps_to_background/res" /> |
| 108 </issue> | 125 </issue> |
| 109 <issue id="ImpliedQuantity" severity="Error"> | 126 <issue id="ImpliedQuantity" severity="Error"> |
| 110 <ignore regexp="gen/chrome/android/chrome_strings_grd" /> | 127 <ignore regexp="gen/chrome/android/chrome_strings_grd" /> |
| 111 </issue> | 128 </issue> |
| 112 <issue id="InconsistentArrays" severity="Error"> | 129 <issue id="InconsistentArrays" severity="Error"> |
| 113 <ignore regexp="gen/android_webview/locale_paks.resources.zip/values/locale- paks.xml" /> | 130 <ignore regexp="gen/android_webview/locale_paks.resources.zip/values/locale- paks.xml" /> |
| 114 <ignore regexp="gen/chrome/android/chrome_locale_paks.resources.zip/values/l ocale-paks.xml" /> | 131 <ignore regexp="gen/chrome/android/chrome_locale_paks.resources.zip/values/l ocale-paks.xml" /> |
| 115 </issue> | 132 </issue> |
| 116 <issue id="InconsistentLayout" severity="ignore" /> | 133 <issue id="InconsistentLayout" severity="ignore" /> |
| (...skipping 20 matching lines...) Expand all Loading... | |
| 137 <issue id="MissingQuantity"> | 154 <issue id="MissingQuantity"> |
| 138 <ignore regexp="android_chrome_strings.xml" /> | 155 <ignore regexp="android_chrome_strings.xml" /> |
| 139 </issue> | 156 </issue> |
| 140 <issue id="MissingRegistered" severity="ignore" /> | 157 <issue id="MissingRegistered" severity="ignore" /> |
| 141 <issue id="MissingSuperCall" severity="Error"> | 158 <issue id="MissingSuperCall" severity="Error"> |
| 142 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/widget/s election/SelectionToolbar.java" /> | 159 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/widget/s election/SelectionToolbar.java" /> |
| 143 </issue> | 160 </issue> |
| 144 <issue id="MissingTranslation"> | 161 <issue id="MissingTranslation"> |
| 145 <ignore regexp="blimp/client/app/android/java/res/values/arrays.xml" /> | 162 <ignore regexp="blimp/client/app/android/java/res/values/arrays.xml" /> |
| 146 <!-- http://crbug.com/450548 --> | 163 <!-- http://crbug.com/450548 --> |
| 164 <ignore regexp="chromecast/internal" /> | |
| 147 <ignore regexp="restriction_values.xml.*" /> | 165 <ignore regexp="restriction_values.xml.*" /> |
| 148 </issue> | 166 </issue> |
| 149 <issue id="MissingVersion"> | 167 <issue id="MissingVersion"> |
| 150 <ignore path="AndroidManifest.xml" /> | 168 <ignore path="AndroidManifest.xml" /> |
| 151 </issue> | 169 </issue> |
| 152 <issue id="NewApi"> | 170 <issue id="NewApi"> |
| 153 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17" /> | 171 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17" /> |
| 154 <ignore regexp="chrome/android/java/res/values-v17/styles.xml" /> | 172 <ignore regexp="chrome/android/java/res/values-v17/styles.xml" /> |
| 155 <ignore regexp="chrome/android/java/res/drawable/downloads_big.xml" /> | 173 <ignore regexp="chrome/android/java/res/drawable/downloads_big.xml" /> |
| 174 <ignore regexp="chromecast/internal" /> | |
| 175 <ignore regexp="com/android/tv" /> | |
| 156 <ignore regexp="com/android/webview/chromium/WebViewChromiumFactoryProvider. class" /> | 176 <ignore regexp="com/android/webview/chromium/WebViewChromiumFactoryProvider. class" /> |
| 157 <ignore regexp="com/chrome/cloud/experimental/airspeed/BenchmarksTest.class" /> | 177 <ignore regexp="com/chrome/cloud/experimental/airspeed/BenchmarksTest.class" /> |
| 178 <ignore regexp="com/google/android/apps/cast" /> | |
| 179 <ignore regexp="com/google/android/apps/mediashell" /> | |
| 158 <ignore regexp="org/chromium/base/AnimationFrameTimeHistogram.*Recorder.clas s" /> | 180 <ignore regexp="org/chromium/base/AnimationFrameTimeHistogram.*Recorder.clas s" /> |
| 159 <ignore regexp="org/chromium/base/JavaHandlerThread.class" /> | 181 <ignore regexp="org/chromium/base/JavaHandlerThread.class" /> |
| 160 <ignore regexp="org/chromium/base/SysUtils.class" /> | 182 <ignore regexp="org/chromium/base/SysUtils.class" /> |
| 161 <ignore regexp="org/chromium/chrome/browser/TtsPlatformImpl.class" /> | 183 <ignore regexp="org/chromium/chrome/browser/TtsPlatformImpl.class" /> |
| 162 <ignore regexp="org/chromium/chrome/browser/ntp/IncognitoNewTabPage.class" / > | 184 <ignore regexp="org/chromium/chrome/browser/ntp/IncognitoNewTabPage.class" / > |
| 163 <ignore regexp="org/chromium/chrome/browser/ntp/NewTabPage.class" /> | 185 <ignore regexp="org/chromium/chrome/browser/ntp/NewTabPage.class" /> |
| 164 <ignore regexp="org/chromium/chromecast/base/CastSettingsManager.class" /> | 186 <ignore regexp="org/chromium/chromecast/base/CastSettingsManager.class" /> |
| 165 <ignore regexp="org/chromium/memconsumer/MemConsumer.*.class" /> | 187 <ignore regexp="org/chromium/memconsumer/MemConsumer.*.class" /> |
| 166 <ignore regexp="org/chromium/memconsumer/ResidentService.class" /> | 188 <ignore regexp="org/chromium/memconsumer/ResidentService.class" /> |
| 167 <ignore regexp="org/chromium/mojo/bindings/ValidationTest.class" /> | 189 <ignore regexp="org/chromium/mojo/bindings/ValidationTest.class" /> |
| (...skipping 12 matching lines...) Expand all Loading... | |
| 180 <issue id="Recycle" severity="ignore" /> | 202 <issue id="Recycle" severity="ignore" /> |
| 181 <issue id="Registered" severity="ignore" /> | 203 <issue id="Registered" severity="ignore" /> |
| 182 <issue id="RtlCompat" severity="ignore" /> | 204 <issue id="RtlCompat" severity="ignore" /> |
| 183 <issue id="RtlEnabled" severity="ignore" /> | 205 <issue id="RtlEnabled" severity="ignore" /> |
| 184 <issue id="RtlSymmetry" severity="ignore" /> | 206 <issue id="RtlSymmetry" severity="ignore" /> |
| 185 <issue id="SdCardPath"> | 207 <issue id="SdCardPath"> |
| 186 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /MediaResourceGetter.java" /> | 208 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /MediaResourceGetter.java" /> |
| 187 </issue> | 209 </issue> |
| 188 <issue id="SetJavaScriptEnabled" severity="ignore" /> | 210 <issue id="SetJavaScriptEnabled" severity="ignore" /> |
| 189 <issue id="SignatureOrSystemPermissions" severity="ignore" /> | 211 <issue id="SignatureOrSystemPermissions" severity="ignore" /> |
| 212 <issue id="SpUsage" severity="Error"> | |
| 213 <ignore regexp="chromecast/internal" /> | |
| 214 </issue> | |
| 190 <issue id="StringFormatCount" severity="Error"> | 215 <issue id="StringFormatCount" severity="Error"> |
| 191 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p l/android_chrome_strings.xml" /> | 216 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p l/android_chrome_strings.xml" /> |
| 192 </issue> | 217 </issue> |
| 193 <issue id="StringFormatInvalid" severity="Error"> | 218 <issue id="StringFormatInvalid" severity="Error"> |
| 194 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-c s/android_chrome_strings.xml" /> | 219 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-c s/android_chrome_strings.xml" /> |
| 195 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-d a/android_chrome_strings.xml" /> | 220 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-d a/android_chrome_strings.xml" /> |
| 196 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p l/android_chrome_strings.xml" /> | 221 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p l/android_chrome_strings.xml" /> |
| 197 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-s v/android_chrome_strings.xml" /> | 222 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-s v/android_chrome_strings.xml" /> |
| 198 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-t l/android_chrome_strings.xml" /> | 223 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-t l/android_chrome_strings.xml" /> |
| 199 </issue> | 224 </issue> |
| 225 <issue id="TextFields" severity="Error"> | |
| 226 <ignore regexp="chromecast/internal" /> | |
| 227 </issue> | |
| 200 <issue id="TypographyDashes" severity="Error"> | 228 <issue id="TypographyDashes" severity="Error"> |
| 201 <ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml" /> | 229 <ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml" /> |
| 202 </issue> | 230 </issue> |
| 203 <issue id="Typos" severity="Error"> | 231 <issue id="Typos" severity="Error"> |
| 204 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a ndroid_chrome_strings.xml" /> | 232 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a ndroid_chrome_strings.xml" /> |
| 205 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p t-rBR/android_chrome_strings.xml" /> | 233 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p t-rBR/android_chrome_strings.xml" /> |
| 206 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p t-rPT/android_chrome_strings.xml" /> | 234 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-p t-rPT/android_chrome_strings.xml" /> |
| 207 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-t r/android_chrome_strings.xml" /> | 235 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-t r/android_chrome_strings.xml" /> |
| 208 </issue> | 236 </issue> |
| 209 <issue id="UnusedAttribute" severity="ignore" /> | 237 <issue id="UnusedAttribute" severity="ignore" /> |
| (...skipping 20 matching lines...) Expand all Loading... | |
| 230 <!-- | 258 <!-- |
| 231 This file isn't used if the target SDK version is less than 24. | 259 This file isn't used if the target SDK version is less than 24. |
| 232 TODO(estevenson) remove this and the conditional inclusion in | 260 TODO(estevenson) remove this and the conditional inclusion in |
| 233 AndroidManifest.xml after rolling to SDK 24. | 261 AndroidManifest.xml after rolling to SDK 24. |
| 234 --> | 262 --> |
| 235 <ignore regexp="chrome/android/java/res/xml/network_security_config.xml" /> | 263 <ignore regexp="chrome/android/java/res/xml/network_security_config.xml" /> |
| 236 <ignore regexp="chrome/android/java/res/values/dimens.xml" /> | 264 <ignore regexp="chrome/android/java/res/values/dimens.xml" /> |
| 237 <ignore regexp="chrome/android/java/res/values/ids.xml" /> | 265 <ignore regexp="chrome/android/java/res/values/ids.xml" /> |
| 238 <ignore regexp="chrome/android/webapk/shell_apk/res/layout/main.xml" /> | 266 <ignore regexp="chrome/android/webapk/shell_apk/res/layout/main.xml" /> |
| 239 <ignore regexp="chromecast/browser/android/apk/res/values/strings.xml" /> | 267 <ignore regexp="chromecast/browser/android/apk/res/values/strings.xml" /> |
| 268 <ignore regexp="chromecast/internal" /> | |
| 240 <ignore regexp="clank" /> | 269 <ignore regexp="clank" /> |
| 241 <ignore regexp="gen/android_webview/locale_paks.resources.zip/values/locale- paks.xml" /> | 270 <ignore regexp="gen/android_webview/locale_paks.resources.zip/values/locale- paks.xml" /> |
| 242 <ignore regexp="gen/android_webview/strings_grd.resources.zip/values/android _webview_strings.xml" /> | 271 <ignore regexp="gen/android_webview/strings_grd.resources.zip/values/android _webview_strings.xml" /> |
| 243 <ignore regexp="gen/blimp/client/blimp_strings_grd.resources.zip/values/andr oid_blimp_strings.xml" /> | 272 <ignore regexp="gen/blimp/client/blimp_strings_grd.resources.zip/values/andr oid_blimp_strings.xml" /> |
| 244 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a ndroid_chrome_strings.xml" /> | 273 <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/a ndroid_chrome_strings.xml" /> |
| 245 <ignore regexp="gen/components/strings/components_strings_grd.resources.zip/ values.*/components_strings.xml" /> | 274 <ignore regexp="gen/components/strings/components_strings_grd.resources.zip/ values.*/components_strings.xml" /> |
| 246 <ignore regexp="gen/remoting/resources/strings_java.resources.zip/values/rem oting_strings.xml" /> | 275 <ignore regexp="gen/remoting/resources/strings_java.resources.zip/values/rem oting_strings.xml" /> |
| 247 <ignore regexp="remoting/android/java/res/layout/navigation_list_item.xml" / > | 276 <ignore regexp="remoting/android/java/res/layout/navigation_list_item.xml" / > |
| 248 <!-- Used by Android's policies system --> | 277 <!-- Used by Android's policies system --> |
| 249 <ignore regexp="restriction_values.xml" /> | 278 <ignore regexp="restriction_values.xml" /> |
| 250 </issue> | 279 </issue> |
| 251 <issue id="UseCompoundDrawables"> | 280 <issue id="UseCompoundDrawables"> |
| 252 <ignore regexp="chrome/android/java/res/layout/download_content.xml" /> | 281 <ignore regexp="chrome/android/java/res/layout/download_content.xml" /> |
| 282 <ignore regexp="chromecast/internal" /> | |
| 253 </issue> | 283 </issue> |
| 254 <issue id="UselessParent"> | 284 <issue id="UselessParent"> |
| 255 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml" /> | 285 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml" /> |
| 256 <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activi ty_account_authenticator.xml" /> | 286 <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activi ty_account_authenticator.xml" /> |
| 257 <ignore regexp="chrome/android/java/res/layout/data_reduction_promo_screen.x ml" /> | 287 <ignore regexp="chrome/android/java/res/layout/data_reduction_promo_screen.x ml" /> |
| 288 <ignore regexp="chromecast/internal" /> | |
|
estevenson
2016/08/29 04:21:39
nit: unindent
slan
2016/08/29 14:01:34
Done.
| |
| 258 </issue> | 289 </issue> |
| 259 <issue id="UsesMinSdkAttributes" severity="Error"> | 290 <issue id="UsesMinSdkAttributes" severity="Error"> |
| 260 <ignore regexp="AndroidManifest.xml" /> | 291 <ignore regexp="AndroidManifest.xml" /> |
| 261 </issue> | 292 </issue> |
| 262 <issue id="ValidFragment" severity="Error"> | 293 <issue id="ValidFragment" severity="Error"> |
| 263 <ignore regexp="blimp/client/app/android/javatests/src/org/chromium/blimp/co re/settings/BlimpPreferencesTest.java" /> | 294 <ignore regexp="blimp/client/app/android/javatests/src/org/chromium/blimp/co re/settings/BlimpPreferencesTest.java" /> |
| 264 <ignore regexp="blimp/client/app/android/javatests/src/org/chromium/blimp/co re/settings/MockPreferences.java" /> | 295 <ignore regexp="blimp/client/app/android/javatests/src/org/chromium/blimp/co re/settings/MockPreferences.java" /> |
| 265 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/BaseMediaRouteDialogManager.java" /> | 296 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/BaseMediaRouteDialogManager.java" /> |
| 266 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteChooserDialogManager.java" /> | 297 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteChooserDialogManager.java" /> |
| 267 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteControllerDialogManager.java" /> | 298 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteControllerDialogManager.java" /> |
| 268 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen ces/privacy/OtherFormsOfHistoryDialogFragment.java" /> | 299 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen ces/privacy/OtherFormsOfHistoryDialogFragment.java" /> |
| 269 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java" /> | 300 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java" /> |
| 270 </issue> | 301 </issue> |
| 271 <issue id="ViewConstructor" severity="ignore" /> | 302 <issue id="ViewConstructor" severity="ignore" /> |
| 272 <issue id="WrongCall" severity="ignore" /> | 303 <issue id="WrongCall" severity="ignore" /> |
| 273 <issue id="WrongConstant"> | 304 <issue id="WrongConstant"> |
| 274 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java" /> | 305 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java" /> |
| 275 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java" /> | 306 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java" /> |
| 276 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java" /> | 307 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java" /> |
| 277 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java" /> | 308 <ignore regexp="content/public/android/java/src/org/chromium/content/browser /ChildProcessConnectionImpl.java" /> |
| 278 </issue> | 309 </issue> |
| 279 </lint> | 310 </lint> |
| OLD | NEW |