Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2241233002: Reland of Fail builds when lint warnings are generated. (Closed)

Created:
4 years, 4 months ago by estevenson
Modified:
4 years, 3 months ago
Reviewers:
agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fail builds when lint warnings are generated. Previous: https://codereview.chromium.org/2241973002/ Original issue: https://codereview.chromium.org/2240573004/ Suppress all existing lint warnings so that builds will fail when new warnings are generated. New lint warnings that are generated in files that are ignored in suppressions.xml will not be caught. However, now we can remove lint warnings on a file by file basis instead of having to fix all lint warnings before making lint break builds. BUG=607761 Committed: https://crrev.com/166a7cf0a0545439141f2e2fec69010f05c3f499 Cr-Commit-Position: refs/heads/master@{#414708}

Patch Set 1 #

Patch Set 2 : Rebase + add more suppressions + fix order of suppressions #

Patch Set 3 : rebase + add more suppressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -71 lines) Patch
M build/android/gyp/lint.py View 1 1 chunk +4 lines, -1 line 0 comments Download
M build/android/lint/suppressions.xml View 1 2 1 chunk +209 lines, -70 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
estevenson
ptal Andrew! This should work now that the same version of lint is used upstream ...
4 years, 4 months ago (2016-08-24 20:34:47 UTC) #3
agrieve
lgtm!
4 years, 4 months ago (2016-08-25 01:03:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241233002/40001
4 years, 3 months ago (2016-08-26 14:35:44 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-26 14:39:46 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 14:41:48 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/166a7cf0a0545439141f2e2fec69010f05c3f499
Cr-Commit-Position: refs/heads/master@{#414708}

Powered by Google App Engine
This is Rietveld 408576698