[layoutng] Implement state machine for async layout

[layoutng] Implement state machine for async layout

This turned out to be more involved than I expected, because I had to make
more classes garbage-collected in order to make them members.

I later learned that I could have gotten by with not making some of them
gc'd and instead just tracing them (as described in the last part of "Field
Errors" in https://www.chromium.org/developers/blink-gc-plugin-errors), so let
me know if you want me to go back to that approach.

This also removes NGBoxIterator in favor of just traversing nextSibling
manually; with the async code, this works more naturally. I also
changed NGBox to always point to a layout object, and using nullptr
when it is not pointing to one, with it being garbage collected that
also worked more naturally that way.

R=eae@chromium.org, ikilpatrick@chromium.org, glebl@chromium.org
BUG=635619
Committed: https://chromium.googlesource.com/chromium/src/+/610b75f9d65f2e849fd6505e21c475020862f6e9

[cbiesinger, 2016-08-26 23:19:23]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 23:20:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-08-26 23:47:38]

LGTM

https://codereview.chromium.org/2284983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2284983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:78: };
ASSERT_NOT_REACHED (or whateher the DCHECK equiv is).

[cbiesinger, 2016-08-29 15:48:03]

The CQ bit was checked by cbiesinger@chromium.org

[cbiesinger, 2016-08-29 15:48:03]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2284983002/#ps40001
(title: "NOTREACHED, also fix the windows compile error")

[commit-bot: I haz the power, 2016-08-29 15:48:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-29 15:49:20]

https://codereview.chromium.org/2284983002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2284983002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:78: };
On 2016/08/26 23:47:38, eae wrote:
> ASSERT_NOT_REACHED (or whateher the DCHECK equiv is).

Done.

[ikilpatrick, 2016-08-29 16:35:51]

lgtm

https://codereview.chromium.org/2284983002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2284983002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:24: switch
(state_) {
what does this look like with interleaved case's? Presumably a little too yuck?

[cbiesinger, 2016-08-29 17:48:22]

The CQ bit was unchecked by cbiesinger@chromium.org

[cbiesinger, 2016-08-29 17:48:27]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-08-29 17:52:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-29 19:43:02]

The CQ bit was unchecked by cbiesinger@chromium.org

[cbiesinger, 2016-08-29 19:43:06]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-08-29 19:51:25]

Description was changed from

==========
[layoutng] Implement state machine for async layout

This turned out to be more involved than I expected, because I had to make
more classes garbage-collected in order to make them members.

I later learned that I could have gotten by with not making some of them
gc'd and instead just tracing them (as described in the last part of "Field
Errors" in https://www.chromium.org/developers/blink-gc-plugin-errors), so let
me know if you want me to go back to that approach.

This also removes NGBoxIterator in favor of just traversing nextSibling
manually; with the async code, this works more naturally. I also
changed NGBox to always point to a layout object, and using nullptr
when it is not pointing to one, with it being garbage collected that
also worked more naturally that way.

R=ikilpatrick@chromium.org,eae@chromium.org,glebl@chromium.org
BUG=635619
==========

to

==========
[layoutng] Implement state machine for async layout

This turned out to be more involved than I expected, because I had to make
more classes garbage-collected in order to make them members.

I later learned that I could have gotten by with not making some of them
gc'd and instead just tracing them (as described in the last part of "Field
Errors" in https://www.chromium.org/developers/blink-gc-plugin-errors), so let
me know if you want me to go back to that approach.

This also removes NGBoxIterator in favor of just traversing nextSibling
manually; with the async code, this works more naturally. I also
changed NGBox to always point to a layout object, and using nullptr
when it is not pointing to one, with it being garbage collected that
also worked more naturally that way.

R=eae@chromium.org, ikilpatrick@chromium.org, glebl@chromium.org
BUG=635619

Committed: https://crrev.com/610b75f9d65f2e849fd6505e21c475020862f6e9
Cr-Commit-Position: refs/heads/master@{#415027}
==========

[commit-bot: I haz the power, 2016-08-29 19:51:26]

Patchset 3 (id:??) landed as
https://crrev.com/610b75f9d65f2e849fd6505e21c475020862f6e9
Cr-Commit-Position: refs/heads/master@{#415027}

[cbiesinger, 2016-08-29 19:52:26]

Description was changed from

==========
[layoutng] Implement state machine for async layout

This turned out to be more involved than I expected, because I had to make
more classes garbage-collected in order to make them members.

I later learned that I could have gotten by with not making some of them
gc'd and instead just tracing them (as described in the last part of "Field
Errors" in https://www.chromium.org/developers/blink-gc-plugin-errors), so let
me know if you want me to go back to that approach.

This also removes NGBoxIterator in favor of just traversing nextSibling
manually; with the async code, this works more naturally. I also
changed NGBox to always point to a layout object, and using nullptr
when it is not pointing to one, with it being garbage collected that
also worked more naturally that way.

R=eae@chromium.org, ikilpatrick@chromium.org, glebl@chromium.org
BUG=635619

Committed: https://crrev.com/610b75f9d65f2e849fd6505e21c475020862f6e9
Cr-Commit-Position: refs/heads/master@{#415027}
==========

to

==========
[layoutng] Implement state machine for async layout

This turned out to be more involved than I expected, because I had to make
more classes garbage-collected in order to make them members.

I later learned that I could have gotten by with not making some of them
gc'd and instead just tracing them (as described in the last part of "Field
Errors" in https://www.chromium.org/developers/blink-gc-plugin-errors), so let
me know if you want me to go back to that approach.

This also removes NGBoxIterator in favor of just traversing nextSibling
manually; with the async code, this works more naturally. I also
changed NGBox to always point to a layout object, and using nullptr
when it is not pointing to one, with it being garbage collected that
also worked more naturally that way.

R=eae@chromium.org, ikilpatrick@chromium.org, glebl@chromium.org
BUG=635619

Committed:
https://chromium.googlesource.com/chromium/src/+/610b75f9d65f2e849fd6505e21c4...
==========

[cbiesinger, 2016-08-29 19:52:28]

Committed patchset #3 (id:40001) manually as
610b75f9d65f2e849fd6505e21c475020862f6e9 (presubmit successful).