Remove V8_CALL macro

Remove V8_CALL macro

This CL replaces V8_CALL with To().

BUG=625512
Committed: https://crrev.com/c1c833f0285826dbba4a8ff2392ac280b293de8b
Cr-Commit-Position: refs/heads/master@{#416504}

[haraken, 2016-08-26 11:02:41]

haraken@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2016-08-26 11:02:42]

PTAL

[Yuki, 2016-08-26 15:25:01]

https://codereview.chromium.org/2284623002/diff/1/third_party/WebKit/Source/b...
File
third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
(right):

https://codereview.chromium.org/2284623002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp:73:
return value->BooleanValue(isolate->GetCurrentContext()).ToChecked();
s/value/result/

Did you compile the CL?

|result| is a return value from m_callback.  I guess it can be any value.
Is it okay to convert, for example, a function to a boolean?
In that case, doesn't ToCheck() cause a crash?

https://codereview.chromium.org/2284623002/diff/1/third_party/WebKit/Source/b...
File
third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp
(right):

https://codereview.chromium.org/2284623002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp:129:
if (!info[1]->BooleanValue(context).To(&bubbles))
I think it's not guaranteed that info.Length() > 1.
info[1] may be an empty handle?

[haraken, 2016-09-05 00:45:43]

PTAL

https://codereview.chromium.org/2284623002/diff/1/third_party/WebKit/Source/b...
File
third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
(right):

https://codereview.chromium.org/2284623002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp:73:
return value->BooleanValue(isolate->GetCurrentContext()).ToChecked();
On 2016/08/26 15:25:01, Yuki wrote:
> s/value/result/
> 
> Did you compile the CL?
> 
> |result| is a return value from m_callback.  I guess it can be any value.
> Is it okay to convert, for example, a function to a boolean?
> In that case, doesn't ToCheck() cause a crash?

Done.

https://codereview.chromium.org/2284623002/diff/1/third_party/WebKit/Source/b...
File
third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp
(right):

https://codereview.chromium.org/2284623002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp:129:
if (!info[1]->BooleanValue(context).To(&bubbles))
On 2016/08/26 15:25:01, Yuki wrote:
> I think it's not guaranteed that info.Length() > 1.
> info[1] may be an empty handle?

In that case, info[1] returns v8::Undefined. So this conversion should be okay.

https://cs.chromium.org/chromium/src/v8/include/v8.h?sq=package:chromium&dr=C...

However, this custom binding is wrong in many ways, so we need to update it.

[Yuki, 2016-09-05 04:44:12]

lgtm

[haraken, 2016-09-05 04:47:18]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-09-05 04:47:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 06:21:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-05 06:23:35]

Description was changed from

==========
Remove V8_CALL macro

This CL replaces V8_CALL with To().

BUG=625512
==========

to

==========
Remove V8_CALL macro

This CL replaces V8_CALL with To().

BUG=625512

Committed: https://crrev.com/c1c833f0285826dbba4a8ff2392ac280b293de8b
Cr-Commit-Position: refs/heads/master@{#416504}
==========

[commit-bot: I haz the power, 2016-09-05 06:23:36]

Patchset 2 (id:??) landed as
https://crrev.com/c1c833f0285826dbba4a8ff2392ac280b293de8b
Cr-Commit-Position: refs/heads/master@{#416504}