Remove V8_CALL macro

third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp

 /*
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *  * Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  *  * Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 30 matching lines @@
     v8::Local<v8::Context> context = isolate->GetCurrentContext();
     v8::Local<v8::Object> object;
     if (!value->ToObject(context).ToLocal(&object))
         return nullptr;
 
     v8::Local<v8::Value> xValue;
     if (!object->Get(context, v8AtomicString(isolate, "x")).ToLocal(&xValue))
         return nullptr;
     bool canProvideX = !isUndefinedOrNull(xValue);
     double x;
-    V8_CALL(x, xValue, NumberValue(context), return nullptr);
+    if (!xValue->NumberValue(context).To(&x))
+        return nullptr;
 
     v8::Local<v8::Value> yValue;
     if (!object->Get(context, v8AtomicString(isolate, "y")).ToLocal(&yValue))
         return nullptr;
     bool canProvideY = !isUndefinedOrNull(yValue);
     double y;
-    V8_CALL(y, yValue, NumberValue(context), return nullptr);
+    if (!yValue->NumberValue(context).To(&y))
+        return nullptr;
 
     v8::Local<v8::Value> zValue;
     if (!object->Get(context, v8AtomicString(isolate, "z")).ToLocal(&zValue))
         return nullptr;
     bool canProvideZ = !isUndefinedOrNull(zValue);
     double z;
-    V8_CALL(z, zValue, NumberValue(context), return nullptr);
+    if (!zValue->NumberValue(context).To(&z))
+        return nullptr;
 
     if (!canProvideX && !canProvideY && !canProvideZ)
         return nullptr;
 
     return DeviceMotionData::Acceleration::create(canProvideX, x, canProvideY, y, canProvideZ, z);
 }
 
 DeviceMotionData::RotationRate* readRotationRateArgument(v8::Local<v8::Value> value, v8::Isolate* isolate)
 {
     if (isUndefinedOrNull(value))
         return nullptr;
 
     v8::Local<v8::Context> context = isolate->GetCurrentContext();
     v8::Local<v8::Object> object;
     if (!value->ToObject(context).ToLocal(&object))
         return nullptr;
 
     v8::Local<v8::Value> alphaValue;
     if (!object->Get(context, v8AtomicString(isolate, "alpha")).ToLocal(&alphaValue))
         return nullptr;
     bool canProvideAlpha = !isUndefinedOrNull(alphaValue);
     double alpha;
-    V8_CALL(alpha, alphaValue, NumberValue(context), return nullptr);
+    if (!alphaValue->NumberValue(context).To(&alpha))
+        return nullptr;
 
     v8::Local<v8::Value> betaValue;
     if (!object->Get(context, v8AtomicString(isolate, "beta")).ToLocal(&betaValue))
         return nullptr;
     bool canProvideBeta = !isUndefinedOrNull(betaValue);
     double beta;
-    V8_CALL(beta, betaValue, NumberValue(context), return nullptr);
+    if (!betaValue->NumberValue(context).To(&beta))
+        return nullptr;
 
     v8::Local<v8::Value> gammaValue;
     if (!object->Get(context, v8AtomicString(isolate, "gamma")).ToLocal(&gammaValue))
         return nullptr;
     bool canProvideGamma = !isUndefinedOrNull(gammaValue);
     double gamma;
-    V8_CALL(gamma, gammaValue, NumberValue(context), return nullptr);
+    if (!gammaValue->NumberValue(context).To(&gamma))
+        return nullptr;
 
     if (!canProvideAlpha && !canProvideBeta && !canProvideGamma)
         return nullptr;
 
     return DeviceMotionData::RotationRate::create(canProvideAlpha, alpha, canProvideBeta, beta, canProvideGamma, gamma);
 }
 
 } // namespace
 
 void V8DeviceMotionEvent::initDeviceMotionEventMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
+    // TODO(haraken): This custom binding should mimic auto-generated code more.
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "initDeviceMotionEvent", "DeviceMotionEvent", info.Holder(), info.GetIsolate());
     DeviceMotionEvent* impl = V8DeviceMotionEvent::toImpl(info.Holder());
     v8::Isolate* isolate = info.GetIsolate();
     V8StringResource<> type(info[0]);
     if (!type.prepare())
         return;
     v8::Local<v8::Context> context = info.GetIsolate()->GetCurrentContext();
     bool bubbles = false;
-    V8_CALL(bubbles, info[1], BooleanValue(context), return);
+    if (!info[1]->BooleanValue(context).To(&bubbles))

[Yuki, 2016/08/26 15:25:01]

I think it's not guaranteed that info.Length() > 1.
info[1] may be an empty handle?

[haraken, 2016/09/05 00:45:42]

In that case, info[1] returns v8::Undefined. So this conversion should be okay.

https://cs.chromium.org/chromium/src/v8/include/v8.h?sq=package:chromium&dr=C...

However, this custom binding is wrong in many ways, so we need to update it.

+        return;
     bool cancelable = false;
-    V8_CALL(cancelable, info[2], BooleanValue(context), return);
+    if (!info[2]->BooleanValue(context).To(&cancelable))
+        return;
     DeviceMotionData::Acceleration* acceleration = readAccelerationArgument(info[3], isolate);
     DeviceMotionData::Acceleration* accelerationIncludingGravity = readAccelerationArgument(info[4], isolate);
     DeviceMotionData::RotationRate* rotationRate = readRotationRateArgument(info[5], isolate);
     bool intervalProvided = !isUndefinedOrNull(info[6]);
     double interval = 0;
     if (intervalProvided) {
         interval = toRestrictedDouble(isolate, info[6], exceptionState);
         if (exceptionState.throwIfNeeded())
             return;
     }
     DeviceMotionData* deviceMotionData = DeviceMotionData::create(acceleration, accelerationIncludingGravity, rotationRate, intervalProvided, interval);
     impl->initDeviceMotionEvent(type, bubbles, cancelable, deviceMotionData);
 }
 
 } // namespace blink