Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp

Issue 2284623002: Remove V8_CALL macro (Closed)
Patch Set: temp Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (c) 2009, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 v8::Local<v8::Value> result; 64 v8::Local<v8::Value> result;
65 // FIXME: This comment doesn't make much sense given what the code is actual ly doing. 65 // FIXME: This comment doesn't make much sense given what the code is actual ly doing.
66 // 66 //
67 // Step 6: If the error callback returns false, then move on to the next 67 // Step 6: If the error callback returns false, then move on to the next
68 // statement, if any, or onto the next overall step otherwise. Otherwise, 68 // statement, if any, or onto the next overall step otherwise. Otherwise,
69 // the error callback did not return false, or there was no error callback. 69 // the error callback did not return false, or there was no error callback.
70 // Jump to the last step in the overall steps. 70 // Jump to the last step in the overall steps.
71 if (!V8ScriptRunner::callFunction(m_callback.newLocal(isolate), getExecution Context(), m_scriptState->context()->Global(), WTF_ARRAY_LENGTH(argv), argv, iso late).ToLocal(&result)) 71 if (!V8ScriptRunner::callFunction(m_callback.newLocal(isolate), getExecution Context(), m_scriptState->context()->Global(), WTF_ARRAY_LENGTH(argv), argv, iso late).ToLocal(&result))
72 return true; 72 return true;
73
74 bool value; 73 bool value;
75 V8_CALL(value, result, BooleanValue(isolate->GetCurrentContext()), return tr ue); 74 if (!result->BooleanValue(isolate->GetCurrentContext()).To(&value))
75 return true;
76 return value; 76 return value;
77 } 77 }
78 78
79 } // namespace blink 79 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698