[Android] Add AndroidSpellChecker feature to allow for gradual rollout using finch.

[Android] Add AndroidSpellChecker feature to allow for gradual rollout using finch.

This patch replaces the kEnableAndroidSpellChecker flag with two
features "AndroidSpellChecker" and "AndroidSpellCheckerNonLowEnd".
This is to allow for finch testing (using chrome experimentation
framework) on e.g. canary and dev channels to verify stability
and obtain potential crash logs.

BUG=583616, 629609
Committed: https://crrev.com/34b1ffd11bd0976a3772c4697f7936e8b01b5601
Cr-Commit-Position: refs/heads/master@{#415936}

[timvolodine, 2016-08-26 20:54:13]

timvolodine@chromium.org changed reviewers:
+ tobiasjs@chromium.org, torne@chromium.org

[Tobias Sargeant, 2016-08-30 10:39:52]

https://codereview.chromium.org/2284583002/diff/1/android_webview/browser/aw_...
File android_webview/browser/aw_content_browser_client.cc (left):

https://codereview.chromium.org/2284583002/diff/1/android_webview/browser/aw_...
android_webview/browser/aw_content_browser_client.cc:229:
spellcheck::switches::kEnableAndroidSpellChecker)) {
How does webview turn on the spellcheck feature now?

https://codereview.chromium.org/2284583002/diff/1/components/spellcheck/commo...
File components/spellcheck/common/spellcheck_features.h (right):

https://codereview.chromium.org/2284583002/diff/1/components/spellcheck/commo...
components/spellcheck/common/spellcheck_features.h:14: extern const
base::Feature kAndroidSpellCheckerNonLowEnd;
Not mentioned anywhere except here? I agree that being able to switch it off for
low end devices is a good idea (for the moment, at least) but maybe we should
just make that the behaviour of kAndroidSpellChecker?

[timvolodine, 2016-08-30 13:17:42]

https://codereview.chromium.org/2284583002/diff/1/android_webview/browser/aw_...
File android_webview/browser/aw_content_browser_client.cc (left):

https://codereview.chromium.org/2284583002/diff/1/android_webview/browser/aw_...
android_webview/browser/aw_content_browser_client.cc:229:
spellcheck::switches::kEnableAndroidSpellChecker)) {
On 2016/08/30 10:39:52, Tobias Sargeant wrote:
> How does webview turn on the spellcheck feature now?

it's a feature now, so will be able to do something like:
--enable-features=AndroidSpellChecker

https://codereview.chromium.org/2284583002/diff/1/components/spellcheck/commo...
File components/spellcheck/common/spellcheck_features.h (right):

https://codereview.chromium.org/2284583002/diff/1/components/spellcheck/commo...
components/spellcheck/common/spellcheck_features.h:14: extern const
base::Feature kAndroidSpellCheckerNonLowEnd;
On 2016/08/30 10:39:52, Tobias Sargeant wrote:
> Not mentioned anywhere except here? I agree that being able to switch it off
for
> low end devices is a good idea (for the moment, at least) but maybe we should
> just make that the behaviour of kAndroidSpellChecker?

yes, my idea was to be able to experiment with the AndroidSpellCheckerNonLowEnd
on our side to make it potentially not too disruptive for the users. While
having the global kAndroidSpellChecker feature for all other purposes. The
"NonLowEnd" could go away in the future when it's ready.

Admittedly I've probably been biased by
https://codereview.chromium.org/1508713002 in considering low-end devices as an
'early exit'. But it seems to make sense..

[Tobias Sargeant, 2016-08-31 14:08:58]

LGTM.

[timvolodine, 2016-08-31 18:13:21]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 18:15:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-08-31 18:30:49]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 18:31:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 20:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 20:04:58]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2016-09-01 12:41:59]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-09-01 12:41:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
tobiasjs@chromium.org
Link to the patchset: https://codereview.chromium.org/2284583002/#ps40001
(title: "fix compile")

[commit-bot: I haz the power, 2016-09-01 12:42:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 12:45:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-01 12:48:05]

Description was changed from

==========
[Android] Add AndroidSpellChecker feature to allow for gradual rollout using
finch.

This patch replaces the kEnableAndroidSpellChecker flag with two
features "AndroidSpellChecker" and "AndroidSpellCheckerNonLowEnd".
This is to allow for finch testing (using chrome experimentation
framework) on e.g. canary and dev channels to verify stability
and obtain potential crash logs.

BUG=583616, 629609
==========

to

==========
[Android] Add AndroidSpellChecker feature to allow for gradual rollout using
finch.

This patch replaces the kEnableAndroidSpellChecker flag with two
features "AndroidSpellChecker" and "AndroidSpellCheckerNonLowEnd".
This is to allow for finch testing (using chrome experimentation
framework) on e.g. canary and dev channels to verify stability
and obtain potential crash logs.

BUG=583616, 629609

Committed: https://crrev.com/34b1ffd11bd0976a3772c4697f7936e8b01b5601
Cr-Commit-Position: refs/heads/master@{#415936}
==========

[commit-bot: I haz the power, 2016-09-01 12:48:06]

Patchset 3 (id:??) landed as
https://crrev.com/34b1ffd11bd0976a3772c4697f7936e8b01b5601
Cr-Commit-Position: refs/heads/master@{#415936}