components/spellcheck/common/spellcheck_features.h - Issue 2284583002: [Android] Add AndroidSpellChecker feature to allow for gradual rollout using finch.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/spellcheck/common/spellcheck_features.h

Issue 2284583002: [Android] Add AndroidSpellChecker feature to allow for gradual rollout using finch. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_SPELLCHECK_COMMON_SPELLCHECK_FEATURES_H_

	6 #define COMPONENTS_SPELLCHECK_COMMON_SPELLCHECK_FEATURES_H_

	7

	8 #include "base/feature_list.h"

	9

	10 namespace spellcheck {

	11

	12 #if defined(ENABLE_SPELLCHECK) && defined(OS_ANDROID)

	13 extern const base::Feature kAndroidSpellChecker;

	14 extern const base::Feature kAndroidSpellCheckerNonLowEnd;
	Tobias Sargeant 2016/08/30 10:39:52 Not mentioned anywhere except here? I agree that b Not mentioned anywhere except here? I agree that being able to switch it off for low end devices is a good idea (for the moment, at least) but maybe we should just make that the behaviour of kAndroidSpellChecker? timvolodine 2016/08/30 13:17:42 yes, my idea was to be able to experiment with the Show quoted text On 2016/08/30 10:39:52, Tobias Sargeant wrote: > Not mentioned anywhere except here? I agree that being able to switch it off for > low end devices is a good idea (for the moment, at least) but maybe we should > just make that the behaviour of kAndroidSpellChecker? yes, my idea was to be able to experiment with the AndroidSpellCheckerNonLowEnd on our side to make it potentially not too disruptive for the users. While having the global kAndroidSpellChecker feature for all other purposes. The "NonLowEnd" could go away in the future when it's ready. Admittedly I've probably been biased by https://codereview.chromium.org/1508713002 in considering low-end devices as an 'early exit'. But it seems to make sense..
	15

	16 bool IsAndroidSpellCheckFeatureEnabled();

	17 #endif // defined(ENABLE_SPELLCHECK) && defined(OS_ANDROID)

	18

	19 } // namespace spellcheck

	20

	21 #endif // COMPONENTS_SPELLCHECK_COMMON_SPELLCHECK_FEATURES_H_

OLD	NEW