Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1508713002: Disable spellchecker on Android. (Closed)

Created:
5 years ago by Yaron
Modified:
5 years ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, aurimas (slooooooooow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable spellchecker on Android. Changes it so that it's not default-enabled for canary/dev on Android and only configurable by a switch. crbug/415302 will track future work on this feature but for now it's crashing on dev channel and unowned so disabling BUG=513621 Committed: https://crrev.com/97ffb40227f6187782d791bd7fca35889a43e425 Cr-Commit-Position: refs/heads/master@{#364391}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/renderer/spellchecker/spellcheck.cc View 3 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Yaron
bump
5 years ago (2015-12-10 15:33:42 UTC) #3
please use gerrit instead
LGTM
5 years ago (2015-12-10 16:42:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508713002/1
5 years ago (2015-12-10 16:43:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 17:43:39 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-10 17:44:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97ffb40227f6187782d791bd7fca35889a43e425
Cr-Commit-Position: refs/heads/master@{#364391}

Powered by Google App Engine
This is Rietveld 408576698