Put constants in 'C', not '$'.

Put constants in 'C', not '$'.

Currently, dart2js puts all static/top-level elements and constants in one object ($). For large applications, this means that this object may exceed a limit in V8 which turns of the "hidden class" optimization. The effect of this is that all static/top-level method calls get slow.

The solution to this problem appears to have multiple global objects. This CL takes the first step in that direction.

R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26119

[ngeoffray, 2013-08-13 13:06:08]

LGTM!

[sra1, 2013-08-13 22:14:50]

Perhaps you could change the Description to say why?
Do you intent to change the namer and minifier to exploit the separate
namespace?

[ahe, 2013-08-13 22:19:44]

On 2013/08/13 22:14:50, sra1 wrote:
> Perhaps you could change the Description to say why?
> Do you intent to change the namer and minifier to exploit the separate
> namespace?

Update the description with:

Currently, dart2js puts all static/top-level elements and constants in one
object ($). For large applications, this means that this object may exceed a
limit in V8 which turns of the "hidden class" optimization. The effect of this
is that all static/top-level method calls get slow. 

The solution to this problem appears to have multiple global objects. This CL
takes the first step in that direction.

[ahe, 2013-08-14 12:03:58]

On 2013/08/13 22:14:50, sra1 wrote:
> Do you intent to change the namer and minifier to exploit the separate
> namespace?

That didn't occur to me, but I'll file a bug saying that we can do that.

[ahe, 2013-08-14 13:28:36]

Committed patchset #1 manually as r26119 (presubmit successful).