dart/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart - Issue 22835003: Put constants in 'C', not '$'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

Issue 22835003: Put constants in 'C', not '$'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

index ace154a497833dbe25791671a28824c10e9681d5..f1b83d90db798c7f4014705236bb58bcc37e77e5 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

@@ -122,7 +122,7 @@ class ConstantReferenceEmitter implements ConstantVisitor<jsAst.Expression> {

jsAst.Expression emitCanonicalVersion(Constant constant) {

String name = namer.constantName(constant);

return new jsAst.PropertyAccess.field(

- new jsAst.VariableUse(namer.CURRENT_ISOLATE), name);

+ new jsAst.VariableUse(namer.globalObjectForConstant(constant)), name);

}

jsAst.Expression visitList(ListConstant constant) {

« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart » ('j') | no next file with comments »