Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.

Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.

this function return inverse matrix.
if the current matrix is not invertible set all attributes to NaN and set is2D to false.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

 BUG=388780
Committed: https://crrev.com/08a0db183cdeee8d4d4e4c6e75dc3af4f0c9f376
Cr-Commit-Position: refs/heads/master@{#416348}

[Hwanseung Lee, 2016-08-27 11:30:02]

Description was changed from

==========
Implement inverse & invertSelf funtion in DomMatrix & DOMMatrixReadOnly.

add inverse & invertSelf funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

to

==========
Implement inverse & invertSelf funtion in DomMatrix & DOMMatrixReadOnly.

add inverse & invertSelf funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

[Hwanseung Lee, 2016-08-27 11:30:02]

hs1217.lee@samsung.com changed reviewers:
+ jinho.bang@samsung.com, pdr@chromium.org

[Hwanseung Lee, 2016-08-27 11:31:00]

@zino, pdr.  Please take a look. thank you.

[pdr., 2016-08-30 02:14:07]

pdr@chromium.org changed reviewers:
+ dominicc@chromium.org
- pdr@chromium.org

[dominicc (has gone to gerrit), 2016-08-30 02:22:09]

This looks pretty good. A couple of nits inline.

I haven't looked at DOMMatrix in much detail before; could you send me a link to
the intent to ship for these interfaces/methods? Thanks!

https://codereview.chromium.org/2283173003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-invert.html
(right):

https://codereview.chromium.org/2283173003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-invert.html:11:
var matrix2d = new DOMMatrix(new DOMMatrixReadOnly([1, 2, 3, 4, 5, 6]));
Put TODO on this to just create the DOMMatrix directly when the sequence
constructor is supported. Mention that there are lots of instances below, too.

https://codereview.chromium.org/2283173003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/DOMMatrix.cpp (right):

https://codereview.chromium.org/2283173003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DOMMatrix.cpp:126: setM11(std::nan(""));
Hmm, I haven't done any numerical programming with C++, but this is a bit of a
surprise. There's no constant or macro for this?

[zino, 2016-08-30 02:53:33]

On 2016/08/30 02:22:09, dominicc (OOF until 8.26) wrote:
> This looks pretty good. A couple of nits inline.
> 
> I haven't looked at DOMMatrix in much detail before; could you send me a link
to
> the intent to ship for these interfaces/methods? Thanks!
> 

Hi dominicc@,

Thank you for review first. :)

This feature is behind runtime flag yet. Please see: [1]

There was a intent to implement[2] only because I didn't send to intent to ship
yet.

I have a plan to send to intent to ship after finishing syncing up with the spec
once.

[1]
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/Runti...
[2]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/V_bJNtOg0oM/lECG9Sik...

Thanks!

[dominicc (has gone to gerrit), 2016-08-30 03:10:23]

Great. Can you work on the description a little bit?

- Don't repeat what's in the first line.
- Call the interfaces by their exact names--DOMMatrix, not DomMatrix.

Thanks!

[Hwanseung Lee, 2016-08-30 03:16:33]

Description was changed from

==========
Implement inverse & invertSelf funtion in DomMatrix & DOMMatrixReadOnly.

add inverse & invertSelf funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

to

==========
add inverse & invertSelf funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

[Hwanseung Lee, 2016-08-30 03:18:03]

Description was changed from

==========
add inverse & invertSelf funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

to

==========
add inverse & invertSelf funtion in DOMMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

[Hwanseung Lee, 2016-08-30 12:47:06]

@dominicc
i did fix some problem. could you review again?

https://codereview.chromium.org/2283173003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-invert.html
(right):

https://codereview.chromium.org/2283173003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-invert.html:11:
var matrix2d = new DOMMatrix(new DOMMatrixReadOnly([1, 2, 3, 4, 5, 6]));
On 2016/08/30 02:22:09, dominicc wrote:
> Put TODO on this to just create the DOMMatrix directly when the sequence
> constructor is supported. Mention that there are lots of instances below, too.

Done.

https://codereview.chromium.org/2283173003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/DOMMatrix.cpp (right):

https://codereview.chromium.org/2283173003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DOMMatrix.cpp:126: setM11(std::nan(""));
On 2016/08/30 02:22:09, dominicc wrote:
> Hmm, I haven't done any numerical programming with C++, but this is a bit of a
> surprise. There's no constant or macro for this?

Done.

[Hwanseung Lee, 2016-08-30 15:36:56]

Description was changed from

==========
add inverse & invertSelf funtion in DOMMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

to

==========
Implement inverse & invertSelf funtion in DOMMatrix & DOMMatrixReadOnly.

add inverse & invertSelf funtion in DOMMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

[Hwanseung Lee, 2016-08-30 15:42:54]

Description was changed from

==========
Implement inverse & invertSelf funtion in DOMMatrix & DOMMatrixReadOnly.

add inverse & invertSelf funtion in DOMMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

to

==========
Implement inverse & invertSelf funtion in DOMMatrix & DOMMatrixReadOnly.

add inverse & invertSelf funtion. it can be to invert matrix.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

[Hwanseung Lee, 2016-08-30 15:48:46]

Description was changed from

==========
Implement inverse & invertSelf funtion in DOMMatrix & DOMMatrixReadOnly.

add inverse & invertSelf funtion. it can be to invert matrix.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

to

==========
Implement inverse & invertSelf funtion in DOMMatrix & DOMMatrixReadOnly.

add inverse & invertSelf funtion. it can be to get inverse matrix.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

[dominicc (has gone to gerrit), 2016-08-31 02:12:24]

Nearly there.

The description needs work:

This part: Implement inverse & invertSelf funtion in DOMMatrix &
DOMMatrixReadOnly.
and this part: add inverse & invertSelf funtion.

are nearly the same. You don't need that second one.

Watch your spelling--funtion
Watch your grammar--it can be to get

I think your top line is fine, and the spec links are good. Just shorten it to
include those two, fix the spelling, and it should be good. Sometimes less is
better.

https://codereview.chromium.org/2283173003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-invert.html
(right):

https://codereview.chromium.org/2283173003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-invert.html:11:
/* TODO create the DOMMatrix directly when the sequence constructor is
supported. */
Use // TODO(your.alias): ...

The text of your TODO is very nice; it explains what to do, when.

[Hwanseung Lee, 2016-08-31 02:15:29]

Description was changed from

==========
Implement inverse & invertSelf funtion in DOMMatrix & DOMMatrixReadOnly.

add inverse & invertSelf funtion. it can be to get inverse matrix.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

to

==========
Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.

it can be to get inverse matrix.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

[dominicc (has gone to gerrit), 2016-08-31 02:17:42]

>
https://codereview.chromium.org/2283173003/diff/20001/third_party/WebKit/Layo...
> File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-invert.html
(right):
> 
>
https://codereview.chromium.org/2283173003/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-invert.html:11:
/* TODO create the DOMMatrix directly when the sequence constructor is
supported. */
> Use // TODO(your.alias): ...
> 
> The text of your TODO is very nice; it explains what to do, when.

By the way, maybe having the same TODO repetitively is distracting. Maybe you
should write a little helper function and put the TODO on *that* that says,
basically what you said, plus remove the function.

Then when you clean it up you can delete the function and just delete all the
calls to it. Something like:

// TODO(you): ...
function init(values) {
  return new DOMMatrixReadOnly(values);
}

var matrix3D = new DOMMatrix(init([1, 1, 1, ...]));

[Hwanseung Lee, 2016-08-31 14:13:32]

Description was changed from

==========
Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.

it can be to get inverse matrix.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

to

==========
Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.

this function return inverse matrix.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

[Hwanseung Lee, 2016-08-31 14:46:15]

Description was changed from

==========
Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.

this function return inverse matrix.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

BUG=388780
==========

to

==========
Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.
    
this function return inverse matrix.
if the current matrix is not invertible set all attributes to NaN
and set is2D to false.
refer to detail spec([1],[2])
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself
    
 BUG=388780
==========

[Hwanseung Lee, 2016-08-31 14:46:58]

Description was changed from

==========
Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.
    
this function return inverse matrix.
if the current matrix is not invertible set all attributes to NaN
and set is2D to false.
refer to detail spec([1],[2])
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself
    
 BUG=388780
==========

to

==========
Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.
    
this function return inverse matrix.
if the current matrix is not invertible set all attributes to NaN and set is2D
to false.
refer to detail spec([1],[2])
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself
    
 BUG=388780
==========

[Hwanseung Lee, 2016-08-31 14:50:11]

@dominicc please review again. thank you.

[dominicc (has gone to gerrit), 2016-09-02 01:25:40]

lgtm

Excellent work.

[Hwanseung Lee, 2016-09-02 01:28:26]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-09-02 01:28:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 03:07:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 03:07:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Hwanseung Lee, 2016-09-02 17:52:01]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2016-09-02 17:52:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2283173003/#ps60001
(title: "fix a global-interface-listing-expected.txt")

[commit-bot: I haz the power, 2016-09-02 17:52:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 21:31:12]

Description was changed from

==========
Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.
    
this function return inverse matrix.
if the current matrix is not invertible set all attributes to NaN and set is2D
to false.
refer to detail spec([1],[2])
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself
    
 BUG=388780
==========

to

==========
Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.
    
this function return inverse matrix.
if the current matrix is not invertible set all attributes to NaN and set is2D
to false.
refer to detail spec([1],[2])
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself
    
 BUG=388780
==========

[commit-bot: I haz the power, 2016-09-02 21:31:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-02 21:33:40]

Description was changed from

==========
Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.
    
this function return inverse matrix.
if the current matrix is not invertible set all attributes to NaN and set is2D
to false.
refer to detail spec([1],[2])
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself
    
 BUG=388780
==========

to

==========
Implement inverse & invertSelf function in DOMMatrix & DOMMatrixReadOnly.

this function return inverse matrix.
if the current matrix is not invertible set all attributes to NaN and set is2D
to false.
refer to detail spec([1],[2])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-inverse
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-invertself

 BUG=388780

Committed: https://crrev.com/08a0db183cdeee8d4d4e4c6e75dc3af4f0c9f376
Cr-Commit-Position: refs/heads/master@{#416348}
==========

[commit-bot: I haz the power, 2016-09-02 21:33:41]

Patchset 4 (id:??) landed as
https://crrev.com/08a0db183cdeee8d4d4e4c6e75dc3af4f0c9f376
Cr-Commit-Position: refs/heads/master@{#416348}