[Chromecast] Set the cast_product_type to the correct value on Android.

[Chromecast] Set the cast_product_type to the correct value on Android.

Before, it was not set anywhere for Android builds, so it was
defaulting to 0, which made the Google Cast app think that it
was a Cast TV.

BUG=Internal b/31097743

Committed: https://crrev.com/a0185eb34799a87d4a275202756f297c3ab1f6af
Cr-Commit-Position: refs/heads/master@{#415529}

[Simeon, 2016-08-27 00:45:45]

sanfin@chromium.org changed reviewers:
+ gfhuang@chromium.org, halliwell@chromium.org, sanfin@chromium.org,
slan@chromium.org

[slan, 2016-08-29 03:11:21]

lgtm after proposed fix.

https://codereview.chromium.org/2282263002/diff/1/chromecast/base/BUILD.gn
File chromecast/base/BUILD.gn (right):

https://codereview.chromium.org/2282263002/diff/1/chromecast/base/BUILD.gn#ne...
chromecast/base/BUILD.gn:13: declare_args() {
Simeon, I take back my earlier comment, could we do something like this instead?

declare_args() {
  # Existing comment.
  if (is_android) {
    cast_product_type = 4
  } else {
    cast_product_type = 0
  }
}

if (is_android) {
  assert(cast_product_type == 4)
} else {
  assert(cast_product_type >= 0 && cast_product_type <= 3)
}

Thanks.

[Simeon, 2016-08-30 21:48:46]

On 2016/08/29 03:11:21, slan wrote:
> lgtm after proposed fix.
> 
> https://codereview.chromium.org/2282263002/diff/1/chromecast/base/BUILD.gn
> File chromecast/base/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2282263002/diff/1/chromecast/base/BUILD.gn#ne...
> chromecast/base/BUILD.gn:13: declare_args() {
> Simeon, I take back my earlier comment, could we do something like this
instead?
> 
> declare_args() {
>   # Existing comment.
>   if (is_android) {
>     cast_product_type = 4
>   } else {
>     cast_product_type = 0
>   }
> }
> 
> if (is_android) {
>   assert(cast_product_type == 4)
> } else {
>   assert(cast_product_type >= 0 && cast_product_type <= 3)
> }
> 
> Thanks.

Done.

[slan, 2016-08-30 21:50:22]

lgtm

[Simeon, 2016-08-30 22:37:52]

The CQ bit was checked by sanfin@chromium.org

[commit-bot: I haz the power, 2016-08-30 22:38:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 01:30:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-31 01:33:30]

Description was changed from

==========
[Chromecast] Set the cast_product_type to the correct value on Android.

Before, it was not set anywhere for Android builds, so it was
defaulting to 0, which made the Google Cast app think that it
was a Cast TV.

BUG=Internal b/31097743
==========

to

==========
[Chromecast] Set the cast_product_type to the correct value on Android.

Before, it was not set anywhere for Android builds, so it was
defaulting to 0, which made the Google Cast app think that it
was a Cast TV.

BUG=Internal b/31097743

Committed: https://crrev.com/a0185eb34799a87d4a275202756f297c3ab1f6af
Cr-Commit-Position: refs/heads/master@{#415529}
==========

[commit-bot: I haz the power, 2016-08-31 01:33:31]

Patchset 2 (id:??) landed as
https://crrev.com/a0185eb34799a87d4a275202756f297c3ab1f6af
Cr-Commit-Position: refs/heads/master@{#415529}