[Chromecast] Set the cast_product_type to the correct value on Android.

chromecast/base/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//chrome/version.gni")  # TODO layering violation!
 import("//chromecast/chromecast.gni")
 import("//testing/test.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
 declare_args() {

[slan, 2016/08/29 03:11:20]

Simeon, I take back my earlier comment, could we do something like this instead?

declare_args() {
  # Existing comment.
  if (is_android) {
    cast_product_type = 4
  } else {
    cast_product_type = 0
  }
}

if (is_android) {
  assert(cast_product_type == 4)
} else {
  assert(cast_product_type >= 0 && cast_product_type <= 3)
}

Thanks.

   # Denotes the type of Cast product. This is #defined as CAST_PRODUCT_TYPE in
   # version.h. This is an integer in the range [0-4].
-  cast_product_type = 0
+  cast_product_type = -1
+}
+
+if (is_android) {
+  assert(cast_product_type == -1)
+  cast_product_type = 4
 }
 
 assert(cast_product_type >= 0 && cast_product_type <= 4)
 
 # GYP target: chromecast.gyp:cast_base
 source_set("base") {
   sources = [
     "android/dumpstate_writer.cc",
     "android/dumpstate_writer.h",
     "android/system_time_change_notifier_android.cc",
@@ skipping 210 matching lines @@
       "$java_src_dir/org/chromium/chromecast/base/ChromecastConfigAndroid.java",
       "$java_src_dir/org/chromium/chromecast/base/DumpstateWriter.java",
       "$java_src_dir/org/chromium/chromecast/base/SystemTimeChangeNotifierAndroid.java",
     ]
 
     deps = [
       "//base:base_java",
     ]
   }
 }