Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chromecast/base/BUILD.gn

Issue 2282263002: [Chromecast] Set the cast_product_type to the correct value on Android. (Closed)
Patch Set: Implement slan@'s suggestions Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//chrome/version.gni") # TODO layering violation! 5 import("//chrome/version.gni") # TODO layering violation!
6 import("//chromecast/chromecast.gni") 6 import("//chromecast/chromecast.gni")
7 import("//testing/test.gni") 7 import("//testing/test.gni")
8 8
9 if (is_android) { 9 if (is_android) {
10 import("//build/config/android/rules.gni") 10 import("//build/config/android/rules.gni")
11 } 11 }
12 12
13 declare_args() { 13 declare_args() {
14 # Denotes the type of Cast product. This is #defined as CAST_PRODUCT_TYPE in 14 # Denotes the type of Cast product. This is #defined as CAST_PRODUCT_TYPE in
15 # version.h. This is an integer in the range [0-4]. 15 # version.h. This is an integer in the range [0-4].
16 cast_product_type = 0 16 if (is_android) {
17 cast_product_type = 4
18 } else {
19 cast_product_type = 0
20 }
17 } 21 }
18 22
19 assert(cast_product_type >= 0 && cast_product_type <= 4) 23 if (is_android) {
24 assert(cast_product_type == 4)
25 } else {
26 assert(cast_product_type >= 0 && cast_product_type <= 3)
27 }
20 28
21 # GYP target: chromecast.gyp:cast_base 29 # GYP target: chromecast.gyp:cast_base
22 source_set("base") { 30 source_set("base") {
23 sources = [ 31 sources = [
24 "android/dumpstate_writer.cc", 32 "android/dumpstate_writer.cc",
25 "android/dumpstate_writer.h", 33 "android/dumpstate_writer.h",
26 "android/system_time_change_notifier_android.cc", 34 "android/system_time_change_notifier_android.cc",
27 "android/system_time_change_notifier_android.h", 35 "android/system_time_change_notifier_android.h",
28 "bind_to_task_runner.h", 36 "bind_to_task_runner.h",
29 "cast_constants.cc", 37 "cast_constants.cc",
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 "$java_src_dir/org/chromium/chromecast/base/ChromecastConfigAndroid.java", 245 "$java_src_dir/org/chromium/chromecast/base/ChromecastConfigAndroid.java",
238 "$java_src_dir/org/chromium/chromecast/base/DumpstateWriter.java", 246 "$java_src_dir/org/chromium/chromecast/base/DumpstateWriter.java",
239 "$java_src_dir/org/chromium/chromecast/base/SystemTimeChangeNotifierAndroi d.java", 247 "$java_src_dir/org/chromium/chromecast/base/SystemTimeChangeNotifierAndroi d.java",
240 ] 248 ]
241 249
242 deps = [ 250 deps = [
243 "//base:base_java", 251 "//base:base_java",
244 ] 252 ]
245 } 253 }
246 } 254 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698