Fix replaying of captured objects during chunk building.

Fix replaying of captured objects during chunk building.

R=titzer@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=16334

[titzer, 2013-08-26 11:27:24]

https://codereview.chromium.org/22819011/diff/3001/src/mips/lithium-mips.cc
File src/mips/lithium-mips.cc (right):

https://codereview.chromium.org/22819011/diff/3001/src/mips/lithium-mips.cc#n...
src/mips/lithium-mips.cc:2364: HEnvironment* env =
current_block_->last_environment();
Can we factor out this code to a platform-independent helper, maybe in a static
method on the HEscapeAnalysisPhase class?

https://codereview.chromium.org/22819011/diff/3001/test/mjsunit/compiler/esca...
File test/mjsunit/compiler/escape-analysis.js (right):

https://codereview.chromium.org/22819011/diff/3001/test/mjsunit/compiler/esca...
test/mjsunit/compiler/escape-analysis.js:137: // Test deoptimization with
captured objects on operand stack.
Do we need to test modifications of the captured objects between assertions here
as well?

[Michael Starzinger, 2013-08-26 16:15:44]

Comments addressed.

https://codereview.chromium.org/22819011/diff/3001/src/mips/lithium-mips.cc
File src/mips/lithium-mips.cc (right):

https://codereview.chromium.org/22819011/diff/3001/src/mips/lithium-mips.cc#n...
src/mips/lithium-mips.cc:2364: HEnvironment* env =
current_block_->last_environment();
On 2013/08/26 11:27:24, titzer wrote:
> Can we factor out this code to a platform-independent helper, maybe in a
static
> method on the HEscapeAnalysisPhase class?

Done. I moved it into a static helper on HCapturedObject.

https://codereview.chromium.org/22819011/diff/3001/test/mjsunit/compiler/esca...
File test/mjsunit/compiler/escape-analysis.js (right):

https://codereview.chromium.org/22819011/diff/3001/test/mjsunit/compiler/esca...
test/mjsunit/compiler/escape-analysis.js:137: // Test deoptimization with
captured objects on operand stack.
On 2013/08/26 11:27:24, titzer wrote:
> Do we need to test modifications of the captured objects between assertions
here
> as well?

Done. I added modifications of fields after the deopt point and also added more
checking of the values after deopt.

[titzer, 2013-08-26 16:29:01]

lgtm

[Michael Starzinger, 2013-08-26 16:43:34]

Committed patchset #3 manually as r16334 (presubmit successful).