Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 22819011: Fix replaying of captured objects during chunk building. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment by Ben Titzer. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2343 matching lines...) Expand 10 before | Expand all | Expand 10 after
2354 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) { 2354 LInstruction* LChunkBuilder::DoArgumentsObject(HArgumentsObject* instr) {
2355 // There are no real uses of the arguments object. 2355 // There are no real uses of the arguments object.
2356 // arguments.length and element access are supported directly on 2356 // arguments.length and element access are supported directly on
2357 // stack arguments, and any real arguments object use causes a bailout. 2357 // stack arguments, and any real arguments object use causes a bailout.
2358 // So this value is never used. 2358 // So this value is never used.
2359 return NULL; 2359 return NULL;
2360 } 2360 }
2361 2361
2362 2362
2363 LInstruction* LChunkBuilder::DoCapturedObject(HCapturedObject* instr) { 2363 LInstruction* LChunkBuilder::DoCapturedObject(HCapturedObject* instr) {
2364 HEnvironment* env = current_block_->last_environment();
2365 instr->ReplayEnvironment(env);
2366
2364 // There are no real uses of a captured object. 2367 // There are no real uses of a captured object.
2365 return NULL; 2368 return NULL;
2366 } 2369 }
2367 2370
2368 2371
2369 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) { 2372 LInstruction* LChunkBuilder::DoAccessArgumentsAt(HAccessArgumentsAt* instr) {
2370 info()->MarkAsRequiresFrame(); 2373 info()->MarkAsRequiresFrame();
2371 LOperand* args = UseRegister(instr->arguments()); 2374 LOperand* args = UseRegister(instr->arguments());
2372 LOperand* length; 2375 LOperand* length;
2373 LOperand* index; 2376 LOperand* index;
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
2510 2513
2511 2514
2512 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2515 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2513 LOperand* object = UseRegister(instr->object()); 2516 LOperand* object = UseRegister(instr->object());
2514 LOperand* index = UseRegister(instr->index()); 2517 LOperand* index = UseRegister(instr->index());
2515 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2518 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2516 } 2519 }
2517 2520
2518 2521
2519 } } // namespace v8::internal 2522 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698