Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2281373002: [Android] Do not immediately delete skipped crash dump uploads. (Closed)

Created:
4 years, 3 months ago by Ilya Sherman
Modified:
4 years, 3 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Do not immediately delete skipped crash dump uploads. This will give users a chance to decide to manually upload any skipped crashes, which can be useful when reporting bugs. This CL pairs nicely with [ https://codereview.chromium.org/2280313002/ ], which adds some heuristics to clean up old/obsolete crash reports. BUG=641628 TEST=CrashFileManagerTest.*, MinidumpUploadCallableTest.* R=gayane@chromium.org Committed: https://crrev.com/17ad87db2d875747460f05b46a1f1032b57c77b9 Cr-Commit-Position: refs/heads/master@{#415103}

Patch Set 1 #

Messages

Total messages: 18 (9 generated)
Ilya Sherman
4 years, 3 months ago (2016-08-27 06:20:30 UTC) #1
gayane -on leave until 09-2017
lgtm
4 years, 3 months ago (2016-08-29 17:23:44 UTC) #6
Ilya Sherman
+Maria for OWNERS approval
4 years, 3 months ago (2016-08-29 19:01:05 UTC) #8
gayane -on leave until 09-2017
As owners for this CL and your other CL are not the same maybe just ...
4 years, 3 months ago (2016-08-29 19:12:15 UTC) #9
Ilya Sherman
On 2016/08/29 19:12:15, gayane wrote: > As owners for this CL and your other CL ...
4 years, 3 months ago (2016-08-29 19:16:20 UTC) #11
Maria
lgtm
4 years, 3 months ago (2016-08-29 20:50:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281373002/1
4 years, 3 months ago (2016-08-29 21:19:24 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 04:37:49 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:39:19 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17ad87db2d875747460f05b46a1f1032b57c77b9
Cr-Commit-Position: refs/heads/master@{#415103}

Powered by Google App Engine
This is Rietveld 408576698