Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java

Issue 2281373002: [Android] Do not immediately delete skipped crash dump uploads. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java
index 49fdc450340b8dcf2b6b31f6334f470f953ea971..f5b671a2361e53a84ad7aff54ee1b3bfb55526e0 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java
@@ -174,4 +174,20 @@ public class CrashFileManagerTest extends CrashTestCase {
assertEquals("f.tryN.dmp.try1",
CrashFileManager.filenameWithIncrementedAttemptNumber("f.tryN.dmp"));
}
+
+ @SmallTest
+ @Feature({"Android-AppBase"})
+ public void testMarkUploadSuccess() {
+ CrashFileManager.markUploadSuccess(mDmpFile1);
+ assertFalse(mDmpFile1.exists());
+ assertTrue(new File(mCrashDir, "123_abc.up0").exists());
+ }
+
+ @SmallTest
+ @Feature({"Android-AppBase"})
+ public void testMarkUploadSkipped() {
+ CrashFileManager.markUploadSkipped(mDmpFile1);
+ assertFalse(mDmpFile1.exists());
+ assertTrue(new File(mCrashDir, "123_abc.skipped0").exists());
+ }
}

Powered by Google App Engine
This is Rietveld 408576698