Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java

Issue 2281373002: [Android] Do not immediately delete skipped crash dump uploads. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java
index 7498fe4e54940c4792c0b3f307a2891e835cf18e..5c6713d2b4a474b6807d04ad80572361fc97c922 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java
@@ -241,7 +241,11 @@ public class MinidumpUploadCallableTest extends CrashTestCase {
new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
assertEquals(MinidumpUploadCallable.UPLOAD_USER_DISABLED,
minidumpUploadCallable.call().intValue());
- assertTrue(mExpectedFileAfterUpload.exists());
+
+ File expectedSkippedFileAfterUpload =
+ new File(mCrashDir, mTestUpload.getName().replaceFirst("\\.dmp", ".skipped"));
+ assertTrue(expectedSkippedFileAfterUpload.exists());
+ assertFalse(mExpectedFileAfterUpload.exists());
}
@SmallTest
@@ -289,7 +293,11 @@ public class MinidumpUploadCallableTest extends CrashTestCase {
new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
assertEquals(MinidumpUploadCallable.UPLOAD_DISABLED_BY_SAMPLING,
minidumpUploadCallable.call().intValue());
- assertTrue(mExpectedFileAfterUpload.exists());
+
+ File expectedSkippedFileAfterUpload =
+ new File(mCrashDir, mTestUpload.getName().replaceFirst("\\.dmp", ".skipped"));
+ assertTrue(expectedSkippedFileAfterUpload.exists());
+ assertFalse(mExpectedFileAfterUpload.exists());
}
@SmallTest
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698