Slightly nicer icon.js APIs.

Slightly nicer icon.js APIs.

Eliminate getSupportedScaleFactors() from the publicly-exposed list.  The lone
external caller of this is in iOS-specific code where just using
window.devicePixelRatio directly is currently equivalent.  Arguably, if it
weren't necessarily equivalent, the calling code that unconditionally used the
0th returned element would have been wrong anyway.

getProfileAvatarIcon() isn't really profile-avatar-specific; it's general fixup
for any URL that could be a chrome://theme/ URL, and I want to use it outside
profile avatars.  Rename to the more generic GetImage().  (I couldn't think of a
more specific name that was any good.)

Rename getFaviconImageSet() to getFavicon(), partly to be more parallel with the
above, partly because calling out ImageSet didn't seem to make the callers
clearer, just more verbose.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dbeam

Committed: https://crrev.com/574fb00df48b99dde0ccc1a81447416e730647d6
Cr-Commit-Position: refs/heads/master@{#416370}

[Peter Kasting, 2016-08-26 06:56:05]

Description was changed from

==========
Simplify icon.js APIs.

Eliminate getSupportedScaleFactors() from the publicly-exposed list.  The lone
external caller of this is in iOS-specific code where just using
window.devicePixelRatio directly is currently equivalent.  Arguably, if it
weren't necessarily equivalent, the calling code that unconditionally used the
0th returned element would have been wrong anyway.

getProfileAvatarIcon() isn't really profile-avatar-specific; it's general fixup
for any URL that could be a chrome://theme/ URL, and I want to use it outside
profile avatars.  Rename to the more generic GetImage().  (I couldn't think of a
more specific name that was any good.)

Rename getFaviconImageSet() to getFavicon(), partly to be more parallel with the
above, partly because calling out ImageSet didn't seem to make the callers
clearer, just more verbose.

BUG=none
TEST=none
==========

to

==========
Simplify icon.js APIs.

Eliminate getSupportedScaleFactors() from the publicly-exposed list.  The lone
external caller of this is in iOS-specific code where just using
window.devicePixelRatio directly is currently equivalent.  Arguably, if it
weren't necessarily equivalent, the calling code that unconditionally used the
0th returned element would have been wrong anyway.

getProfileAvatarIcon() isn't really profile-avatar-specific; it's general fixup
for any URL that could be a chrome://theme/ URL, and I want to use it outside
profile avatars.  Rename to the more generic GetImage().  (I couldn't think of a
more specific name that was any good.)

Rename getFaviconImageSet() to getFavicon(), partly to be more parallel with the
above, partly because calling out ImageSet didn't seem to make the callers
clearer, just more verbose.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Peter Kasting, 2016-08-26 06:56:28]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 06:56:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2016-08-26 06:59:38]

Description was changed from

==========
Simplify icon.js APIs.

Eliminate getSupportedScaleFactors() from the publicly-exposed list.  The lone
external caller of this is in iOS-specific code where just using
window.devicePixelRatio directly is currently equivalent.  Arguably, if it
weren't necessarily equivalent, the calling code that unconditionally used the
0th returned element would have been wrong anyway.

getProfileAvatarIcon() isn't really profile-avatar-specific; it's general fixup
for any URL that could be a chrome://theme/ URL, and I want to use it outside
profile avatars.  Rename to the more generic GetImage().  (I couldn't think of a
more specific name that was any good.)

Rename getFaviconImageSet() to getFavicon(), partly to be more parallel with the
above, partly because calling out ImageSet didn't seem to make the callers
clearer, just more verbose.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Slightly nicer icon.js APIs.

Eliminate getSupportedScaleFactors() from the publicly-exposed list.  The lone
external caller of this is in iOS-specific code where just using
window.devicePixelRatio directly is currently equivalent.  Arguably, if it
weren't necessarily equivalent, the calling code that unconditionally used the
0th returned element would have been wrong anyway.

getProfileAvatarIcon() isn't really profile-avatar-specific; it's general fixup
for any URL that could be a chrome://theme/ URL, and I want to use it outside
profile avatars.  Rename to the more generic GetImage().  (I couldn't think of a
more specific name that was any good.)

Rename getFaviconImageSet() to getFavicon(), partly to be more parallel with the
above, partly because calling out ImageSet didn't seem to make the callers
clearer, just more verbose.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Peter Kasting, 2016-08-26 06:59:47]

pkasting@chromium.org changed reviewers:
+ dpapad@chromium.org, eugenebut@chromium.org, jyquinn@chromium.org

[Peter Kasting, 2016-08-26 06:59:59]

jyquinn: ios/chrome/app/resources/history/ OWNERS
eugenebut: ios/web/ OWNERS
dpapad: rest

[commit-bot: I haz the power, 2016-08-26 09:17:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 09:17:54]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-08-26 13:03:33]

ios/web lgtm

I tested window.devicePixelRatio on iOS9 Simulator and it return 2 for iPhone5S
and 3 for iPhone6Plus.

[Jackie Quinn, 2016-08-29 18:15:58]

On 2016/08/26 13:03:33, Eugene But wrote:
> ios/web lgtm
> 
> I tested window.devicePixelRatio on iOS9 Simulator and it return 2 for
iPhone5S
> and 3 for iPhone6Plus.

ios/chrome/app/resources/history lgtm

[Peter Kasting, 2016-09-01 22:13:52]

ping dpapad

[Peter Kasting, 2016-09-01 22:37:05]

pkasting@chromium.org changed reviewers:
+ michaelpg@chromium.org
- dpapad@chromium.org

[Peter Kasting, 2016-09-01 22:37:06]

Thanks for letting me know!  Changing reviewer to michaelpg.

[michaelpg, 2016-09-02 20:00:38]

nice! lgtm

https://codereview.chromium.org/2280853002/diff/1/ios/web/webui/resources/web...
File ios/web/webui/resources/web_ui_favicons.js (right):

https://codereview.chromium.org/2280853002/diff/1/ios/web/webui/resources/web...
ios/web/webui/resources/web_ui_favicons.js:13:
goog.provide('__crWeb.webUIFavicons');
unfamiliar with ios and goog/Closure, so just a question: was this for cr.icon.*
or chrome.send('webui.requestFavicon', ...)?

I ask because presumably something somewhere is including icon.js that no longer
needs to include it, if this follows IWYU.

https://codereview.chromium.org/2280853002/diff/1/ui/webui/resources/js/icon.js
File ui/webui/resources/js/icon.js (right):

https://codereview.chromium.org/2280853002/diff/1/ui/webui/resources/js/icon....
ui/webui/resources/js/icon.js:62: * path.  Resources in chrome://theme have
multiple supported scale factors.
opt nit: single space after period for consistency

[Peter Kasting, 2016-09-02 20:21:42]

https://codereview.chromium.org/2280853002/diff/1/ios/web/webui/resources/web...
File ios/web/webui/resources/web_ui_favicons.js (right):

https://codereview.chromium.org/2280853002/diff/1/ios/web/webui/resources/web...
ios/web/webui/resources/web_ui_favicons.js:13:
goog.provide('__crWeb.webUIFavicons');
(For posterity, we discussed this offline and concluded that no changes are
needed)

[Peter Kasting, 2016-09-02 20:21:49]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-09-02 20:22:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 20:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 20:32:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Kasting, 2016-09-02 20:36:44]

Description was changed from

==========
Slightly nicer icon.js APIs.

Eliminate getSupportedScaleFactors() from the publicly-exposed list.  The lone
external caller of this is in iOS-specific code where just using
window.devicePixelRatio directly is currently equivalent.  Arguably, if it
weren't necessarily equivalent, the calling code that unconditionally used the
0th returned element would have been wrong anyway.

getProfileAvatarIcon() isn't really profile-avatar-specific; it's general fixup
for any URL that could be a chrome://theme/ URL, and I want to use it outside
profile avatars.  Rename to the more generic GetImage().  (I couldn't think of a
more specific name that was any good.)

Rename getFaviconImageSet() to getFavicon(), partly to be more parallel with the
above, partly because calling out ImageSet didn't seem to make the callers
clearer, just more verbose.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Slightly nicer icon.js APIs.

Eliminate getSupportedScaleFactors() from the publicly-exposed list.  The lone
external caller of this is in iOS-specific code where just using
window.devicePixelRatio directly is currently equivalent.  Arguably, if it
weren't necessarily equivalent, the calling code that unconditionally used the
0th returned element would have been wrong anyway.

getProfileAvatarIcon() isn't really profile-avatar-specific; it's general fixup
for any URL that could be a chrome://theme/ URL, and I want to use it outside
profile avatars.  Rename to the more generic GetImage().  (I couldn't think of a
more specific name that was any good.)

Rename getFaviconImageSet() to getFavicon(), partly to be more parallel with the
above, partly because calling out ImageSet didn't seem to make the callers
clearer, just more verbose.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dbeam
==========

[Peter Kasting, 2016-09-02 20:36:44]

pkasting@chromium.org changed reviewers:
+ dbeam@chromium.org

[Peter Kasting, 2016-09-02 20:37:08]

TBR=dbeam for mechanical changes in chrome/browser/resources/{history,options}/

[Peter Kasting, 2016-09-02 20:37:20]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-09-02 20:37:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 22:36:13]

Description was changed from

==========
Slightly nicer icon.js APIs.

Eliminate getSupportedScaleFactors() from the publicly-exposed list.  The lone
external caller of this is in iOS-specific code where just using
window.devicePixelRatio directly is currently equivalent.  Arguably, if it
weren't necessarily equivalent, the calling code that unconditionally used the
0th returned element would have been wrong anyway.

getProfileAvatarIcon() isn't really profile-avatar-specific; it's general fixup
for any URL that could be a chrome://theme/ URL, and I want to use it outside
profile avatars.  Rename to the more generic GetImage().  (I couldn't think of a
more specific name that was any good.)

Rename getFaviconImageSet() to getFavicon(), partly to be more parallel with the
above, partly because calling out ImageSet didn't seem to make the callers
clearer, just more verbose.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dbeam
==========

to

==========
Slightly nicer icon.js APIs.

Eliminate getSupportedScaleFactors() from the publicly-exposed list.  The lone
external caller of this is in iOS-specific code where just using
window.devicePixelRatio directly is currently equivalent.  Arguably, if it
weren't necessarily equivalent, the calling code that unconditionally used the
0th returned element would have been wrong anyway.

getProfileAvatarIcon() isn't really profile-avatar-specific; it's general fixup
for any URL that could be a chrome://theme/ URL, and I want to use it outside
profile avatars.  Rename to the more generic GetImage().  (I couldn't think of a
more specific name that was any good.)

Rename getFaviconImageSet() to getFavicon(), partly to be more parallel with the
above, partly because calling out ImageSet didn't seem to make the callers
clearer, just more verbose.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dbeam
==========

[commit-bot: I haz the power, 2016-09-02 22:36:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-02 22:37:41]

Description was changed from

==========
Slightly nicer icon.js APIs.

Eliminate getSupportedScaleFactors() from the publicly-exposed list.  The lone
external caller of this is in iOS-specific code where just using
window.devicePixelRatio directly is currently equivalent.  Arguably, if it
weren't necessarily equivalent, the calling code that unconditionally used the
0th returned element would have been wrong anyway.

getProfileAvatarIcon() isn't really profile-avatar-specific; it's general fixup
for any URL that could be a chrome://theme/ URL, and I want to use it outside
profile avatars.  Rename to the more generic GetImage().  (I couldn't think of a
more specific name that was any good.)

Rename getFaviconImageSet() to getFavicon(), partly to be more parallel with the
above, partly because calling out ImageSet didn't seem to make the callers
clearer, just more verbose.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dbeam
==========

to

==========
Slightly nicer icon.js APIs.

Eliminate getSupportedScaleFactors() from the publicly-exposed list.  The lone
external caller of this is in iOS-specific code where just using
window.devicePixelRatio directly is currently equivalent.  Arguably, if it
weren't necessarily equivalent, the calling code that unconditionally used the
0th returned element would have been wrong anyway.

getProfileAvatarIcon() isn't really profile-avatar-specific; it's general fixup
for any URL that could be a chrome://theme/ URL, and I want to use it outside
profile avatars.  Rename to the more generic GetImage().  (I couldn't think of a
more specific name that was any good.)

Rename getFaviconImageSet() to getFavicon(), partly to be more parallel with the
above, partly because calling out ImageSet didn't seem to make the callers
clearer, just more verbose.

BUG=none
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dbeam

Committed: https://crrev.com/574fb00df48b99dde0ccc1a81447416e730647d6
Cr-Commit-Position: refs/heads/master@{#416370}
==========

[commit-bot: I haz the power, 2016-09-02 22:37:43]

Patchset 1 (id:??) landed as
https://crrev.com/574fb00df48b99dde0ccc1a81447416e730647d6
Cr-Commit-Position: refs/heads/master@{#416370}