chrome/browser/resources/options/search_engine_manager_engine_list.js - Issue 2280853002: Slightly nicer icon.js APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 2280853002: Slightly nicer icon.js APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/profiles_icon_grid.js ('k') | chrome/browser/resources/options/supervised_user_list.js » ('j') | ios/web/webui/resources/web_ui_favicons.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/search_engine_manager_engine_list.js

diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js

index 3d2f8f9854f6963ee22da6bc5dd18b295511fa92..7284ae9ca3af9400ce12a94b3f6e854ae31c6312 100644

--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js

+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js

@@ -123,9 +123,9 @@ cr.define('options.search_engines', function() {

var faviconDivEl = this.ownerDocument.createElement('div');

faviconDivEl.className = 'favicon';

if (!this.isPlaceholder) {

- faviconDivEl.style.backgroundImage = cr.icon.getFaviconImageSet(

- // Force default icon if no iconURL is available.

- engine.iconURL || '');

+ // Force default icon if no iconURL is available.

+ faviconDivEl.style.backgroundImage =

+ cr.icon.getFavicon(engine.iconURL || '');

}

nameColEl.appendChild(faviconDivEl);