ios/chrome/app/resources/history/other_devices.js - Issue 2280853002: Slightly nicer icon.js APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/app/resources/history/other_devices.js

Issue 2280853002: Slightly nicer icon.js APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/app/resources/history/other_devices.js

diff --git a/ios/chrome/app/resources/history/other_devices.js b/ios/chrome/app/resources/history/other_devices.js

index 2f5b77d30f2aeaef8afb6483f513071bf5ecbd8f..0da99b34c01002e662df199f4adfeab4062a02a2 100644

--- a/ios/chrome/app/resources/history/other_devices.js

+++ b/ios/chrome/app/resources/history/other_devices.js

@@ -263,7 +263,7 @@ Device.prototype.createSessionContents_ = function(maxNumTabs) {

numTabsShown++;

var a = createElementWithClassName('a', 'device-tab-entry');

a.href = tab.url;

- a.style.backgroundImage = cr.icon.getFaviconImageSet(tab.url);

+ a.style.backgroundImage = cr.icon.getFavicon(tab.url);

this.addHighlightedText_(a, tab.title);

// Add a tooltip, since it might be ellipsized. The ones that are not

// necessary will be removed once added to the document, so we can