Issue 2280543003: Remove snippet_id from ImageFetchedCallback

Issue 2280543003: Remove snippet_id from ImageFetchedCallback (Closed)

Created:
4 years, 3 months ago by Philipp Keck

Modified:
4 years, 3 months ago

Reviewers:
Marc Treib

CC:
chromium-reviews, ntp-dev+reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove snippet_id from ImageFetchedCallback BUG=None Committed: https://crrev.com/f29505db79d942dd3f0cd11620624c0192cab941 Cr-Commit-Position: refs/heads/master@{#414709}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -29 lines)			Patch
M	chrome/browser/android/ntp/ntp_snippets_bridge.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/android/ntp/ntp_snippets_bridge.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/ntp_snippets/content_suggestions_provider.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	components/ntp_snippets/content_suggestions_service.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	components/ntp_snippets/content_suggestions_service.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	components/ntp_snippets/content_suggestions_service_unittest.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	components/ntp_snippets/ntp_snippets_service.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	components/ntp_snippets/ntp_snippets_service_unittest.cc	View	2 chunks	+6 lines, -13 lines	0 comments	Download
M	components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

Marc Treib

LGTM, but this will conflict (trivially) with https://codereview.chromium.org/2255783002/. Please wait for that to land first.

4 years, 3 months ago (2016-08-25 13:01:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280543003/1

4 years, 3 months ago (2016-08-26 12:48:27 UTC) #5

commit-bot: I haz the power

4 years, 3 months ago (2016-08-26 14:48:33 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f29505db79d942dd3f0cd11620624c0192cab941
Cr-Commit-Position: refs/heads/master@{#414709}