components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc - Issue 2280543003: Remove snippet_id from ImageFetchedCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

Issue 2280543003: Remove snippet_id from ImageFetchedCallback (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/ntp_snippets_service_unittest.cc ('k') | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

diff --git a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

index e76f1647ec98bbb32496155865c48f14214805c8..79675d4062de68b7ae7b3e11eb01370ebea09b5c 100644

--- a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

+++ b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

@@ -147,7 +147,7 @@ void OfflinePageSuggestionsProvider::FetchSuggestionImage(

// TODO(pke): Fetch proper thumbnail from OfflinePageModel once it's available

// there.

base::ThreadTaskRunnerHandle::Get()->PostTask(

- FROM_HERE, base::Bind(callback, suggestion_id, gfx::Image()));

+ FROM_HERE, base::Bind(callback, gfx::Image()));

}

void OfflinePageSuggestionsProvider::ClearCachedSuggestions(Category category) {