chrome/browser/android/ntp/ntp_snippets_bridge.cc - Issue 2280543003: Remove snippet_id from ImageFetchedCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 2280543003: Remove snippet_id from ImageFetchedCallback (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc

diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc

index f83045503e6a471a6f93fdb9797fd68c792ec047..af6b4a55abb398a9eb1f8b0d937de00e3b7dbaed 100644

--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc

+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc

@@ -324,7 +324,6 @@ void NTPSnippetsBridge::ContentSuggestionsServiceShutdown() {

}

void NTPSnippetsBridge::OnImageFetched(ScopedJavaGlobalRef<jobject> callback,

- const std::string& snippet_id,

const gfx::Image& image) {

ScopedJavaLocalRef<jobject> j_bitmap;

if (!image.IsEmpty())