Add crash keys to debug causes of a crash in RenderFrameImpl::CreateFrame

Add crash keys to debug causes of a crash in RenderFrameImpl::CreateFrame

BUG=626802
Committed: https://crrev.com/6873421b480c8b2716590147e17d2036734304e5
Cr-Commit-Position: refs/heads/master@{#414868}

[alexmos, 2016-08-24 23:59:49]

alexmos@chromium.org changed reviewers:
+ creis@chromium.org, rsesek@chromium.org

[alexmos, 2016-08-24 23:59:50]

Charlie, can you please take a look?  This will help debug the cause of a CHECK
in CreateFrame that seems to imply that we're sending a widget routing id in
FrameMsg_NewFrame for a subframe while not in an OOPIF-enabled mode, which
shouldn't happen.  This will help narrow down the code paths involved, and also
help inspect these values, since these crashes so far are on Mac only, and I
can't easily look at local variables in minidumps.  (Note that this is different
from the other CreateFrame crash in https://crbug.com/591478).

Robert: assuming Charlie's happy, can you please review the crash keys for
owners?

[Charlie Reis, 2016-08-25 00:04:55]

LGTM

https://codereview.chromium.org/2280473002/diff/1/chrome/app/chrome_crash_rep...
File chrome/app/chrome_crash_reporter_client_win.cc (right):

https://codereview.chromium.org/2280473002/diff/1/chrome/app/chrome_crash_rep...
chrome/app/chrome_crash_reporter_client_win.cc:149: {
"newframe_oopifs_possible", kSmallSize },
Wow, there's three places that need this now?  :(

Robert, do you know if there's anything we can do to unify these?  It seems
pretty unfortunate to have to add keys in 3 separate places.  I'll never
remember them all on first try.  :)

[alexmos, 2016-08-25 16:19:45]

The CQ bit was checked by alexmos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 16:20:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alexmos, 2016-08-25 16:27:49]

alexmos@chromium.org changed reviewers:
+ sky@chromium.org

[alexmos, 2016-08-25 16:27:50]

sky@: can you please review the chrome/ crash_keys addition for owners?

[Robert Sesek, 2016-08-25 16:29:06]

lgtm

https://codereview.chromium.org/2280473002/diff/1/chrome/app/chrome_crash_rep...
File chrome/app/chrome_crash_reporter_client_win.cc (right):

https://codereview.chromium.org/2280473002/diff/1/chrome/app/chrome_crash_rep...
chrome/app/chrome_crash_reporter_client_win.cc:149: {
"newframe_oopifs_possible", kSmallSize },
On 2016/08/25 00:04:55, Charlie Reis (OOO til 8-30) wrote:
> Wow, there's three places that need this now?  :(
> 
> Robert, do you know if there's anything we can do to unify these?  It seems
> pretty unfortunate to have to add keys in 3 separate places.  I'll never
> remember them all on first try.  :)

Yeah, this is getting bad, especially as this is popping up in more places. We
unfortunately do need preregistration to ensure we have space enough for the
keys. In Crashpad we're looking at making this better via dynamic storage, but
it's quite tricky to do right in a potentially compromised context.

We may be able to move the registration list into a bare-bones target in
//components/crash, though…

[commit-bot: I haz the power, 2016-08-25 16:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 16:54:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alexmos, 2016-08-25 16:59:30]

The CQ bit was checked by alexmos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 17:00:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 18:03:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 18:03:52]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-25 19:04:55]

LGTM

[alexmos, 2016-08-25 22:56:38]

The CQ bit was checked by alexmos@chromium.org

[alexmos, 2016-08-25 22:56:39]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2280473002/#ps20001
(title: "kSmallSize -> crash_keys::kSmallSize to fix blimp compile error")

[commit-bot: I haz the power, 2016-08-25 22:57:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alexmos, 2016-08-25 22:57:47]

The CQ bit was unchecked by alexmos@chromium.org

[alexmos, 2016-08-26 21:31:23]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:32:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 00:07:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-27 00:10:42]

Description was changed from

==========
Add crash keys to debug causes of a crash in RenderFrameImpl::CreateFrame

BUG=626802
==========

to

==========
Add crash keys to debug causes of a crash in RenderFrameImpl::CreateFrame

BUG=626802

Committed: https://crrev.com/6873421b480c8b2716590147e17d2036734304e5
Cr-Commit-Position: refs/heads/master@{#414868}
==========

[commit-bot: I haz the power, 2016-08-27 00:10:43]

Patchset 2 (id:??) landed as
https://crrev.com/6873421b480c8b2716590147e17d2036734304e5
Cr-Commit-Position: refs/heads/master@{#414868}