Add crash keys to debug causes of a crash in RenderFrameImpl::CreateFrame

chrome/app/chrome_crash_reporter_client_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(ananta/scottmg)
 // Add test coverage for Crashpad.
 #include "chrome/app/chrome_crash_reporter_client_win.h"
 
 #include <assert.h>
 #include <windows.h>
@@ skipping 120 matching lines @@
       // Temporary for https://crbug.com/591478.
       {"initrf_parent_proxy_exists", kSmallSize},
       {"initrf_render_view_is_live", kSmallSize},
       {"initrf_parent_is_in_same_site_instance", kSmallSize},
       {"initrf_parent_process_is_live", kSmallSize},
       {"initrf_root_is_in_same_site_instance", kSmallSize},
       {"initrf_root_is_in_same_site_instance_as_parent", kSmallSize},
       {"initrf_root_process_is_live", kSmallSize},
       {"initrf_root_proxy_is_live", kSmallSize},
 
+      // Temporary for https://crbug.com/626802.
+      { "newframe_routing_id", kSmallSize },
+      { "newframe_proxy_id", kSmallSize },
+      { "newframe_opener_id", kSmallSize },
+      { "newframe_parent_id", kSmallSize },
+      { "newframe_widget_id", kSmallSize },
+      { "newframe_widget_hidden", kSmallSize },
+      { "newframe_replicated_origin", kSmallSize },
+      { "newframe_oopifs_possible", kSmallSize },

[Charlie Reis, 2016/08/25 00:04:55]

Wow, there's three places that need this now?  :(

Robert, do you know if there's anything we can do to unify these?  It seems
pretty unfortunate to have to add keys in 3 separate places.  I'll never
remember them all on first try.  :)

[Robert Sesek, 2016/08/25 16:29:06]

Yeah, this is getting bad, especially as this is popping up in more places. We
unfortunately do need preregistration to ensure we have space enough for the
keys. In Crashpad we're looking at making this better via dynamic storage, but
it's quite tricky to do right in a potentially compromised context.

We may be able to move the registration list into a bare-bones target in
//components/crash, though…

+
       // Temporary for https://crbug.com/630103.
       { "origin_mismatch_url", crash_keys::kLargeSize },
       { "origin_mismatch_origin", crash_keys::kMediumSize },
       { "origin_mismatch_transition", crash_keys::kSmallSize },
       { "origin_mismatch_redirects", crash_keys::kSmallSize },
       { "origin_mismatch_same_page", crash_keys::kSmallSize },
 
       // Temporary for https://crbug.com/612711.
       {"aci_wrong_sp_extension_id", kSmallSize},
 
@@ skipping 215 matching lines @@
 bool ChromeCrashReporterClient::GetCollectStatsInSample() {
   return install_static::GetCollectStatsInSample();
 }
 
 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
     const std::string& process_type) {
   return process_type == install_static::kRendererProcess ||
          process_type == install_static::kPpapiPluginProcess ||
          process_type == install_static::kGpuProcess;
 }