chrome/common/crash_keys.cc - Issue 2280473002: Add crash keys to debug causes of a crash in RenderFrameImpl::CreateFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/crash_keys.cc

Issue 2280473002: Add crash keys to debug causes of a crash in RenderFrameImpl::CreateFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: kSmallSize -> crash_keys::kSmallSize to fix blimp compile error Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/crash_keys.cc

diff --git a/chrome/common/crash_keys.cc b/chrome/common/crash_keys.cc

index c8e1929cf7f7df55c907dbb2ee27b5ef91afb0dd..b547ca44211cb43691a03694e140568080317db3 100644

--- a/chrome/common/crash_keys.cc

+++ b/chrome/common/crash_keys.cc

@@ -193,6 +193,16 @@ size_t RegisterChromeCrashKeys() {

{ "initrf_root_process_is_live", kSmallSize},

{ "initrf_root_proxy_is_live", kSmallSize},

+ // Temporary for https://crbug.com/626802.

+ { "newframe_routing_id", kSmallSize },

+ { "newframe_proxy_id", kSmallSize },

+ { "newframe_opener_id", kSmallSize },

+ { "newframe_parent_id", kSmallSize },

+ { "newframe_widget_id", kSmallSize },

+ { "newframe_widget_hidden", kSmallSize },

+ { "newframe_replicated_origin", kSmallSize },

+ { "newframe_oopifs_possible", kSmallSize },

// Temporary for https://crbug.com/630103.

{ "origin_mismatch_url", crash_keys::kLargeSize },

{ "origin_mismatch_origin", crash_keys::kMediumSize },

« no previous file with comments | « chrome/app/chrome_crash_reporter_client_win.cc ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »