Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2280113002:
[SpellCheck] Add separator if we add "Add to dictionary" option (Closed)
|
Created:
4 years, 3 months ago by Kevin Bailey Modified:
4 years, 3 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[SpellCheck] Add separator if we add "Add to dictionary" option
Add a separator between spelling corrections and "Add to dictionary" so that it's more difficult to accidentally do one or the other.
BUG=613006
Committed: https://crrev.com/698795cdd68c0d2c4fdc4c13d331f41ec7cd47e1
Cr-Commit-Position: refs/heads/master@{#415283}
Patch Set 1 #Patch Set 2 : Only add separator if there are suggestions above it #
Messages
Total messages: 23 (15 generated)
Description was changed from ========== [SpellCheck] Add separator if we add "Add to dictionary" option BUG=613006 ========== to ========== [SpellCheck] Add separator if we add "Add to dictionary" option Add a separator between spelling corrections and "Add to dictionary" so that it's more difficult to accidentally do one or the other. BUG=613006 ==========
krb@chromium.org changed reviewers: + groby@chromium.org
On 2016/08/26 20:10:06, Kevin Bailey wrote: > mailto:krb@chromium.org changed reviewers: > + mailto:groby@chromium.org I don't know that we need a committee to approve this. Seems like a no-brainer to me.
krb@chromium.org changed reviewers: + avi@chromium.org
On 2016/08/26 20:12:14, Kevin Bailey wrote: > On 2016/08/26 20:10:06, Kevin Bailey wrote: > > mailto:krb@chromium.org changed reviewers: > > + mailto:groby@chromium.org > > I don't know that we need a committee to approve this. Seems like a no-brainer > to me. Sorry, didn't look at owners closely enough. avi@, could you take a look?
lgtm Yeah, it needs that.
The CQ bit was checked by krb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM++
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by krb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/29 16:52:58, groby wrote: > LGTM++ Added some small tweaks to make tests pass and handle no suggestions at all. Let me know if anyone sees an issue; I'm committing but happy to follow up any problems.
The CQ bit was checked by krb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org, avi@chromium.org Link to the patchset: https://codereview.chromium.org/2280113002/#ps20001 (title: "Only add separator if there are suggestions above it")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [SpellCheck] Add separator if we add "Add to dictionary" option Add a separator between spelling corrections and "Add to dictionary" so that it's more difficult to accidentally do one or the other. BUG=613006 ========== to ========== [SpellCheck] Add separator if we add "Add to dictionary" option Add a separator between spelling corrections and "Add to dictionary" so that it's more difficult to accidentally do one or the other. BUG=613006 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [SpellCheck] Add separator if we add "Add to dictionary" option Add a separator between spelling corrections and "Add to dictionary" so that it's more difficult to accidentally do one or the other. BUG=613006 ========== to ========== [SpellCheck] Add separator if we add "Add to dictionary" option Add a separator between spelling corrections and "Add to dictionary" so that it's more difficult to accidentally do one or the other. BUG=613006 Committed: https://crrev.com/698795cdd68c0d2c4fdc4c13d331f41ec7cd47e1 Cr-Commit-Position: refs/heads/master@{#415283} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/698795cdd68c0d2c4fdc4c13d331f41ec7cd47e1 Cr-Commit-Position: refs/heads/master@{#415283} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
