[SpellCheck] Add separator if we add "Add to dictionary" option

chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/spelling_menu_observer.h"
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 166 matching lines @@
   EXPECT_EQ(-1, item.command_id);
   EXPECT_FALSE(item.enabled);
   EXPECT_FALSE(item.hidden);
 
   menu()->GetMenuItem(1, &item);
   EXPECT_EQ(IDC_SPELLCHECK_SUGGESTION_0, item.command_id);
   EXPECT_TRUE(item.enabled);
   EXPECT_FALSE(item.hidden);
 
   menu()->GetMenuItem(2, &item);
+  EXPECT_EQ(-1, item.command_id);
+  EXPECT_FALSE(item.enabled);
+  EXPECT_FALSE(item.hidden);
+
+  menu()->GetMenuItem(3, &item);
   EXPECT_EQ(IDC_SPELLCHECK_ADD_TO_DICTIONARY, item.command_id);
   EXPECT_TRUE(item.enabled);
   EXPECT_FALSE(item.hidden);
 
-  menu()->GetMenuItem(3, &item);
+  menu()->GetMenuItem(4, &item);
   EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
   EXPECT_TRUE(item.enabled);
   EXPECT_TRUE(item.checked);
   EXPECT_FALSE(item.hidden);
 
-  menu()->GetMenuItem(4, &item);
+  menu()->GetMenuItem(5, &item);
   EXPECT_EQ(-1, item.command_id);
   EXPECT_FALSE(item.enabled);
   EXPECT_FALSE(item.hidden);
 }
 
 // Test that "Ask Google For Suggestions" is grayed out when using an
 // off the record profile.
 // TODO(rlp): Include graying out of autocorrect in this test when autocorrect
 // is functional.
 IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
@@ skipping 69 matching lines @@
   ForceSuggestMode();
   InitMenu("asdfkj", nullptr);
 
   // Should have at least 2 entries. Separator, suggestion.
   EXPECT_LT(2U, menu()->GetMenuSize());
   menu()->GetMenuItem(0, &item);
   EXPECT_EQ(-1, item.command_id);
   menu()->GetMenuItem(1, &item);
   EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_SUGGESTION, item.command_id);
 }