Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5278)

Unified Diff: chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc

Issue 2280113002: [SpellCheck] Add separator if we add "Add to dictionary" option (Closed)
Patch Set: Only add separator if there are suggestions above it Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_menu_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
diff --git a/chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc b/chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
index 1eebd39cbf486d8dc8e96ba3208997a1e5da0e57..82a4e2980008a48c90f83feff18a36ad976b312a 100644
--- a/chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
+++ b/chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
@@ -184,17 +184,22 @@ IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest,
EXPECT_FALSE(item.hidden);
menu()->GetMenuItem(2, &item);
+ EXPECT_EQ(-1, item.command_id);
+ EXPECT_FALSE(item.enabled);
+ EXPECT_FALSE(item.hidden);
+
+ menu()->GetMenuItem(3, &item);
EXPECT_EQ(IDC_SPELLCHECK_ADD_TO_DICTIONARY, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_FALSE(item.hidden);
- menu()->GetMenuItem(3, &item);
+ menu()->GetMenuItem(4, &item);
EXPECT_EQ(IDC_CONTENT_CONTEXT_SPELLING_TOGGLE, item.command_id);
EXPECT_TRUE(item.enabled);
EXPECT_TRUE(item.checked);
EXPECT_FALSE(item.hidden);
- menu()->GetMenuItem(4, &item);
+ menu()->GetMenuItem(5, &item);
EXPECT_EQ(-1, item.command_id);
EXPECT_FALSE(item.enabled);
EXPECT_FALSE(item.hidden);
« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_menu_observer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698