Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 22801016: Implement highQualityFilter16 so GM doesn't crash when you give it resources. (Closed)

Created:
7 years, 4 months ago by mtklein
Modified:
7 years, 3 months ago
Reviewers:
humper, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Implement highQualityFilter16 so GM doesn't crash when you give it resources. Testing consisted of: 1) ninja -C out/Debug gm && gm -i resources --match mandrill_512 -w /tmp/gm 2) notice that gm didn't segfault 3) look in /tmp/gm and see a bunch of handsome monkeys BUG=skia:1517 R=humper@google.com Committed: https://code.google.com/p/skia/source/detail?r=10917

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -22 lines) Patch
M src/core/SkBitmapFilter.cpp View 3 chunks +29 lines, -12 lines 1 comment Download
M src/core/SkBitmapProcState.h View 3 chunks +10 lines, -6 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/opts/opts_check_SSE2.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
7 years, 4 months ago (2013-08-22 19:28:16 UTC) #1
reed1
https://codereview.chromium.org/22801016/diff/1/src/core/SkBitmapFilter.cpp File src/core/SkBitmapFilter.cpp (right): https://codereview.chromium.org/22801016/diff/1/src/core/SkBitmapFilter.cpp#newcode87 src/core/SkBitmapFilter.cpp:87: highQualityFilter(&SkPackARGB32, s, x, y, colors, count); Have we confirmed ...
7 years, 3 months ago (2013-08-26 13:51:27 UTC) #2
humper
On 2013/08/26 13:51:27, reed1 wrote: > https://codereview.chromium.org/22801016/diff/1/src/core/SkBitmapFilter.cpp > File src/core/SkBitmapFilter.cpp (right): > > https://codereview.chromium.org/22801016/diff/1/src/core/SkBitmapFilter.cpp#newcode87 > ...
7 years, 3 months ago (2013-08-26 14:45:15 UTC) #3
mtklein
7 years, 3 months ago (2013-08-26 16:21:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r10917 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698