Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2280023003: depot_tools: Remove third_party/gsutil (Closed)

Created:
4 years, 3 months ago by Ryan Tseng
Modified:
4 years, 2 months ago
Reviewers:
iannucci, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: Remove third_party/gsutil A quick "git grep gsutil" reveals that this is no longer being used, and all references to gsutil are pointed to gsutil.py. BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/8ea74908a6b6f9ec1ab1a8333d40b54cef0f6f19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -15735 lines) Patch
D third_party/gsutil/CHECKSUM View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/gsutil/COPYING View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/gsutil/LICENSE.third_party View 1 chunk +0 lines, -295 lines 0 comments Download
D third_party/gsutil/MANIFEST.in View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/gsutil/README View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/gsutil/README.chromium View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/gsutil/README.pkg View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/gsutil/ReleaseNotes.txt View 1 chunk +0 lines, -825 lines 0 comments Download
D third_party/gsutil/VERSION View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/gsutil/gslib/README View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/gsutil/gslib/__init__.py View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/__init__.py View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/acls.py View 1 chunk +0 lines, -234 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/anon.py View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/command_opts.py View 1 chunk +0 lines, -116 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/dev.py View 1 chunk +0 lines, -139 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/metadata.py View 1 chunk +0 lines, -186 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/naming.py View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/prod.py View 1 chunk +0 lines, -160 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/projects.py View 1 chunk +0 lines, -130 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/subdirs.py View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/support.py View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/versioning.py View 1 chunk +0 lines, -242 lines 0 comments Download
D third_party/gsutil/gslib/addlhelp/wildcards.py View 1 chunk +0 lines, -170 lines 0 comments Download
D third_party/gsutil/gslib/bucket_listing_ref.py View 1 chunk +0 lines, -175 lines 0 comments Download
D third_party/gsutil/gslib/command.py View 1 chunk +0 lines, -725 lines 0 comments Download
D third_party/gsutil/gslib/command_runner.py View 1 chunk +0 lines, -102 lines 0 comments Download
D third_party/gsutil/gslib/commands/__init__.py View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/gsutil/gslib/commands/cat.py View 1 chunk +0 lines, -131 lines 0 comments Download
D third_party/gsutil/gslib/commands/chacl.py View 1 chunk +0 lines, -523 lines 0 comments Download
D third_party/gsutil/gslib/commands/config.py View 1 chunk +0 lines, -662 lines 0 comments Download
D third_party/gsutil/gslib/commands/cp.py View 1 chunk +0 lines, -1819 lines 0 comments Download
D third_party/gsutil/gslib/commands/disablelogging.py View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/gsutil/gslib/commands/enablelogging.py View 1 chunk +0 lines, -149 lines 0 comments Download
D third_party/gsutil/gslib/commands/getacl.py View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/gsutil/gslib/commands/getcors.py View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/gsutil/gslib/commands/getdefacl.py View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/gsutil/gslib/commands/getlogging.py View 1 chunk +0 lines, -137 lines 0 comments Download
D third_party/gsutil/gslib/commands/getversioning.py View 1 chunk +0 lines, -116 lines 0 comments Download
D third_party/gsutil/gslib/commands/getwebcfg.py View 1 chunk +0 lines, -122 lines 0 comments Download
D third_party/gsutil/gslib/commands/help.py View 1 chunk +0 lines, -218 lines 0 comments Download
D third_party/gsutil/gslib/commands/ls.py View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/gsutil/gslib/commands/mb.py View 1 chunk +0 lines, -172 lines 0 comments Download
D third_party/gsutil/gslib/commands/mv.py View 1 chunk +0 lines, -159 lines 0 comments Download
D third_party/gsutil/gslib/commands/perfdiag.py View 1 chunk +0 lines, -903 lines 0 comments Download
D third_party/gsutil/gslib/commands/rb.py View 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/gsutil/gslib/commands/rm.py View 1 chunk +0 lines, -237 lines 0 comments Download
D third_party/gsutil/gslib/commands/setacl.py View 1 chunk +0 lines, -138 lines 0 comments Download
D third_party/gsutil/gslib/commands/setcors.py View 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/gsutil/gslib/commands/setdefacl.py View 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/gsutil/gslib/commands/setmeta.py View 1 chunk +0 lines, -420 lines 0 comments Download
D third_party/gsutil/gslib/commands/setversioning.py View 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/gsutil/gslib/commands/setwebcfg.py View 1 chunk +0 lines, -190 lines 0 comments Download
D third_party/gsutil/gslib/commands/update.py View 1 chunk +0 lines, -305 lines 0 comments Download
D third_party/gsutil/gslib/commands/version.py View 1 chunk +0 lines, -150 lines 0 comments Download
D third_party/gsutil/gslib/exception.py View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/gsutil/gslib/help_provider.py View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/gsutil/gslib/name_expansion.py View 1 chunk +0 lines, -550 lines 0 comments Download
D third_party/gsutil/gslib/no_op_auth_plugin.py View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/gsutil/gslib/plurality_checkable_iterator.py View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/gsutil/gslib/project_id.py View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/gsutil/gslib/storage_uri_builder.py View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/gsutil/gslib/thread_pool.py View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/gsutil/gslib/util.py View 1 chunk +0 lines, -167 lines 0 comments Download
D third_party/gsutil/gslib/wildcard_iterator.py View 1 chunk +0 lines, -498 lines 0 comments Download
D third_party/gsutil/gsutil View 1 chunk +0 lines, -384 lines 0 comments Download
D third_party/gsutil/gsutil.spec.in View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/gsutil/oauth2_plugin/__init__.py View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/gsutil/oauth2_plugin/oauth2_client.py View 1 chunk +0 lines, -630 lines 0 comments Download
D third_party/gsutil/oauth2_plugin/oauth2_client_test.py View 1 chunk +0 lines, -374 lines 0 comments Download
D third_party/gsutil/oauth2_plugin/oauth2_helper.py View 1 chunk +0 lines, -103 lines 0 comments Download
D third_party/gsutil/oauth2_plugin/oauth2_plugin.py View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/gsutil/pkg_util.py View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/gsutil/plugins/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/gsutil/plugins/sso_auth.py View 1 chunk +0 lines, -105 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
hinoka
4 years, 3 months ago (2016-08-26 22:51:34 UTC) #4
hinoka
Correction, found references in another repo: https://codereview.chromium.org/2284973002/ That has to land first.
4 years, 3 months ago (2016-08-26 23:03:34 UTC) #7
hinoka
The other CL landed, ptal now?
4 years, 3 months ago (2016-09-17 00:01:45 UTC) #8
iannucci
lgtm
4 years, 3 months ago (2016-09-17 00:24:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280023003/1
4 years, 3 months ago (2016-09-19 18:29:49 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/8ea74908a6b6f9ec1ab1a8333d40b54cef0f6f19
4 years, 3 months ago (2016-09-19 18:36:14 UTC) #13
sri
4 years, 2 months ago (2016-10-04 04:16:22 UTC) #14
Message was sent while issue was closed. 
This fix introduced a build failure for older builds w.r.t
https://bugs.chromium.org/p/chromium/issues/detail?id=652564

Powered by Google App Engine
This is Rietveld 408576698