Android: Revert use of SurfaceFactory::RequestCopyOfSurface()

Android: Revert use of SurfaceFactory::RequestCopyOfSurface()

There seems to be some bug in the implmentation in cc::Surfaces.
It looks like it might be swapping an invalid frame when doing
the readback.

This reverts https://codereview.chromium.org/2189493002
and uses the readback layer from
https://codereview.chromium.org/2243663002 instead for issuing
the readback.

For the time being that's totally fine. The main advantage was
that it avoided the need for a browser commit which helps with
trying to do a final readback while the surface goes away (i.e
onPause).

TBR=danakj@chromium.org

BUG=640561
Committed: https://crrev.com/700fe2696c93886d8c71fbf9997d4806d4246715
Cr-Commit-Position: refs/heads/master@{#414604}

[no sievers, 2016-08-25 23:06:16]

Description was changed from

==========
Android: Revert use of SurfaceFactory::RequestCopyOfSurface()

There seems to be some bug in the implmentation in cc::Surfaces.
It looks like it might be swapping an invalid frame when doing
the readback.

This reverts https://codereview.chromium.org/2189493002
and uses the readback layer from
https://codereview.chromium.org/2243663002 instead for issuing
the readback.

For the time being that's totally fine. The main advantage was
that it avoided the need for a browser commit which helps with
trying to do a final readback while the surface goes away (i.e
onPause).

BUG=640561
==========

to

==========
Android: Revert use of SurfaceFactory::RequestCopyOfSurface()

There seems to be some bug in the implmentation in cc::Surfaces.
It looks like it might be swapping an invalid frame when doing
the readback.

This reverts https://codereview.chromium.org/2189493002
and uses the readback layer from
https://codereview.chromium.org/2243663002 instead for issuing
the readback.

For the time being that's totally fine. The main advantage was
that it avoided the need for a browser commit which helps with
trying to do a final readback while the surface goes away (i.e
onPause).

TBR=danakj@chromium.org

BUG=640561
==========

[no sievers, 2016-08-25 23:06:28]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2016-08-25 23:07:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 00:54:59]

Description was changed from

==========
Android: Revert use of SurfaceFactory::RequestCopyOfSurface()

There seems to be some bug in the implmentation in cc::Surfaces.
It looks like it might be swapping an invalid frame when doing
the readback.

This reverts https://codereview.chromium.org/2189493002
and uses the readback layer from
https://codereview.chromium.org/2243663002 instead for issuing
the readback.

For the time being that's totally fine. The main advantage was
that it avoided the need for a browser commit which helps with
trying to do a final readback while the surface goes away (i.e
onPause).

TBR=danakj@chromium.org

BUG=640561
==========

to

==========
Android: Revert use of SurfaceFactory::RequestCopyOfSurface()

There seems to be some bug in the implmentation in cc::Surfaces.
It looks like it might be swapping an invalid frame when doing
the readback.

This reverts https://codereview.chromium.org/2189493002
and uses the readback layer from
https://codereview.chromium.org/2243663002 instead for issuing
the readback.

For the time being that's totally fine. The main advantage was
that it avoided the need for a browser commit which helps with
trying to do a final readback while the surface goes away (i.e
onPause).

TBR=danakj@chromium.org

BUG=640561
==========

[commit-bot: I haz the power, 2016-08-26 00:54:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-26 00:57:10]

Description was changed from

==========
Android: Revert use of SurfaceFactory::RequestCopyOfSurface()

There seems to be some bug in the implmentation in cc::Surfaces.
It looks like it might be swapping an invalid frame when doing
the readback.

This reverts https://codereview.chromium.org/2189493002
and uses the readback layer from
https://codereview.chromium.org/2243663002 instead for issuing
the readback.

For the time being that's totally fine. The main advantage was
that it avoided the need for a browser commit which helps with
trying to do a final readback while the surface goes away (i.e
onPause).

TBR=danakj@chromium.org

BUG=640561
==========

to

==========
Android: Revert use of SurfaceFactory::RequestCopyOfSurface()

There seems to be some bug in the implmentation in cc::Surfaces.
It looks like it might be swapping an invalid frame when doing
the readback.

This reverts https://codereview.chromium.org/2189493002
and uses the readback layer from
https://codereview.chromium.org/2243663002 instead for issuing
the readback.

For the time being that's totally fine. The main advantage was
that it avoided the need for a browser commit which helps with
trying to do a final readback while the surface goes away (i.e
onPause).

TBR=danakj@chromium.org

BUG=640561

Committed: https://crrev.com/700fe2696c93886d8c71fbf9997d4806d4246715
Cr-Commit-Position: refs/heads/master@{#414604}
==========

[commit-bot: I haz the power, 2016-08-26 00:57:11]

Patchset 1 (id:??) landed as
https://crrev.com/700fe2696c93886d8c71fbf9997d4806d4246715
Cr-Commit-Position: refs/heads/master@{#414604}