Android: Attach hidden layer for CopyFromCompositingSurface()

Android: Attach hidden layer for CopyFromCompositingSurface()

When the RenderWidgetHostView becomes invisible we might tear down
the layer, which removes the impl layer from the impl layer,
which will cause the Surface not to be added as a dependant Surface
of the root Surface.

Make sure readbacks actually complete (as long as the display is
drawing) by attaching a hidden layer for the readback Surface.

BUG=636628
TBR=dtrainor@chromium.org

Committed: https://crrev.com/02d8a97db2cf9fdca8042ce72416db6b5fc2abbc
Cr-Commit-Position: refs/heads/master@{#411502}

[no sievers, 2016-08-11 21:49:16]

Description was changed from

==========
Android: Attach hidden layer for CopyFromCompositingSurface()

When the RenderWidgetHostView becomes invisible we might tear down
the layer, which removes the impl layer from the impl layer,
which will cause the Surface not to be added as a dependant Surface
of the root Surface.

Make sure readbacks actually complete (as long as the display is
drawing) by attaching a hidden layer for the readback Surface.

BUG=636628
==========

to

==========
Android: Attach hidden layer for CopyFromCompositingSurface()

When the RenderWidgetHostView becomes invisible we might tear down
the layer, which removes the impl layer from the impl layer,
which will cause the Surface not to be added as a dependant Surface
of the root Surface.

Make sure readbacks actually complete (as long as the display is
drawing) by attaching a hidden layer for the readback Surface.

BUG=636628
==========

[no sievers, 2016-08-11 21:49:17]

sievers@chromium.org changed reviewers:
+ jbauman@chromium.org

[no sievers, 2016-08-11 21:49:23]

ptal

[jbauman, 2016-08-11 22:45:00]

lgtm

[no sievers, 2016-08-11 22:51:19]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2016-08-11 22:52:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 22:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 22:59:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[no sievers, 2016-08-11 23:00:29]

Description was changed from

==========
Android: Attach hidden layer for CopyFromCompositingSurface()

When the RenderWidgetHostView becomes invisible we might tear down
the layer, which removes the impl layer from the impl layer,
which will cause the Surface not to be added as a dependant Surface
of the root Surface.

Make sure readbacks actually complete (as long as the display is
drawing) by attaching a hidden layer for the readback Surface.

BUG=636628
==========

to

==========
Android: Attach hidden layer for CopyFromCompositingSurface()

When the RenderWidgetHostView becomes invisible we might tear down
the layer, which removes the impl layer from the impl layer,
which will cause the Surface not to be added as a dependant Surface
of the root Surface.

Make sure readbacks actually complete (as long as the display is
drawing) by attaching a hidden layer for the readback Surface.

BUG=636628
TBR=dtrainor@chromium.org
==========

[no sievers, 2016-08-11 23:00:36]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2016-08-11 23:03:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 01:07:05]

Description was changed from

==========
Android: Attach hidden layer for CopyFromCompositingSurface()

When the RenderWidgetHostView becomes invisible we might tear down
the layer, which removes the impl layer from the impl layer,
which will cause the Surface not to be added as a dependant Surface
of the root Surface.

Make sure readbacks actually complete (as long as the display is
drawing) by attaching a hidden layer for the readback Surface.

BUG=636628
TBR=dtrainor@chromium.org
==========

to

==========
Android: Attach hidden layer for CopyFromCompositingSurface()

When the RenderWidgetHostView becomes invisible we might tear down
the layer, which removes the impl layer from the impl layer,
which will cause the Surface not to be added as a dependant Surface
of the root Surface.

Make sure readbacks actually complete (as long as the display is
drawing) by attaching a hidden layer for the readback Surface.

BUG=636628
TBR=dtrainor@chromium.org
==========

[commit-bot: I haz the power, 2016-08-12 01:07:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 01:09:46]

Description was changed from

==========
Android: Attach hidden layer for CopyFromCompositingSurface()

When the RenderWidgetHostView becomes invisible we might tear down
the layer, which removes the impl layer from the impl layer,
which will cause the Surface not to be added as a dependant Surface
of the root Surface.

Make sure readbacks actually complete (as long as the display is
drawing) by attaching a hidden layer for the readback Surface.

BUG=636628
TBR=dtrainor@chromium.org
==========

to

==========
Android: Attach hidden layer for CopyFromCompositingSurface()

When the RenderWidgetHostView becomes invisible we might tear down
the layer, which removes the impl layer from the impl layer,
which will cause the Surface not to be added as a dependant Surface
of the root Surface.

Make sure readbacks actually complete (as long as the display is
drawing) by attaching a hidden layer for the readback Surface.

BUG=636628
TBR=dtrainor@chromium.org

Committed: https://crrev.com/02d8a97db2cf9fdca8042ce72416db6b5fc2abbc
Cr-Commit-Position: refs/heads/master@{#411502}
==========

[commit-bot: I haz the power, 2016-08-12 01:09:47]

Patchset 1 (id:??) landed as
https://crrev.com/02d8a97db2cf9fdca8042ce72416db6b5fc2abbc
Cr-Commit-Position: refs/heads/master@{#411502}