Android: Fix some tab placeholder/thumbnail readbacks

Android: Fix some tab placeholder/thumbnail readbacks

There is a problem with readbacks when hiding tabs which
seems to come from the SurfaceLayer being detach from the tree.

I think this was a regression with
https://codereview.chromium.org/1732323002/ which previously
would be resilient to the actual RWHV's layer being detached.

This caused the readback to only complete when you switch back to
a tab and the layer gets reattached sometimes.
Furthermore, it caused tabs to not have placeholders in the cache
at all since TabContentManager has a kMaxReadbacks limit of 1,
so the interrupted readback was preventing other ones also.

The fix is to use the new Surface readback API which
works regardless of the SurfaceLayer's attachment state
and bypasses the UI compositor

BUG=574537
Committed: https://crrev.com/3e5517a5b9a2c05bc1300539337236ccd969b2b2
Cr-Commit-Position: refs/heads/master@{#407980}

[no sievers, 2016-07-26 23:02:33]

Description was changed from

==========
Android: Fix some tab placeholder/thumbnail readbacks

There is a problem with readbacks when hiding tabs which
seems to come from the SurfaceLayer being detach from the tree.

I think this was a regression with
https://codereview.chromium.org/1732323002/ which previously
would be resilient to the actual RWHV's layer being detached.

This caused the readback to only complete when you switch back to
a tab and the layer gets reattached sometimes.
Furthermore, it caused tabs to not have placeholders in the cache
at all since TabContentManager has a kMaxReadbacks limit of 1,
so the interrupted readback was preventing other ones also.

BUG=574537
==========

to

==========
Android: Fix some tab placeholder/thumbnail readbacks

There is a problem with readbacks when hiding tabs which
seems to come from the SurfaceLayer being detach from the tree.

I think this was a regression with
https://codereview.chromium.org/1732323002/ which previously
would be resilient to the actual RWHV's layer being detached.

This caused the readback to only complete when you switch back to
a tab and the layer gets reattached sometimes.
Furthermore, it caused tabs to not have placeholders in the cache
at all since TabContentManager has a kMaxReadbacks limit of 1,
so the interrupted readback was preventing other ones also.

BUG=574537
==========

[no sievers, 2016-07-26 23:02:33]

sievers@chromium.org changed reviewers:
+ danakj@chromium.org

[no sievers, 2016-07-26 23:02:39]

ptal

[no sievers, 2016-07-26 23:19:47]

Description was changed from

==========
Android: Fix some tab placeholder/thumbnail readbacks

There is a problem with readbacks when hiding tabs which
seems to come from the SurfaceLayer being detach from the tree.

I think this was a regression with
https://codereview.chromium.org/1732323002/ which previously
would be resilient to the actual RWHV's layer being detached.

This caused the readback to only complete when you switch back to
a tab and the layer gets reattached sometimes.
Furthermore, it caused tabs to not have placeholders in the cache
at all since TabContentManager has a kMaxReadbacks limit of 1,
so the interrupted readback was preventing other ones also.

BUG=574537
==========

to

==========
Android: Fix some tab placeholder/thumbnail readbacks

There is a problem with readbacks when hiding tabs which
seems to come from the SurfaceLayer being detach from the tree.

I think this was a regression with
https://codereview.chromium.org/1732323002/ which previously
would be resilient to the actual RWHV's layer being detached.

This caused the readback to only complete when you switch back to
a tab and the layer gets reattached sometimes.
Furthermore, it caused tabs to not have placeholders in the cache
at all since TabContentManager has a kMaxReadbacks limit of 1,
so the interrupted readback was preventing other ones also.

The fix is to use the new Surface readback API which
works regardless of the SurfaceLayer's attachment state
and bypasses the UI compositor

BUG=574537
==========

[danakj, 2016-07-26 23:20:12]

LGTM :)

https://codereview.chromium.org/2189493002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2189493002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:895: // Make
sure the layer doesn't get deleted until we fulfill the request.
This comment slightly wrong?

[no sievers, 2016-07-26 23:21:59]

https://codereview.chromium.org/2189493002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2189493002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:895: // Make
sure the layer doesn't get deleted until we fulfill the request.
On 2016/07/26 23:20:12, danakj wrote:
> This comment slightly wrong?

Done.

[no sievers, 2016-07-26 23:22:02]

The CQ bit was checked by sievers@chromium.org

[no sievers, 2016-07-26 23:22:03]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2189493002/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2016-07-26 23:22:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 00:00:23]

Description was changed from

==========
Android: Fix some tab placeholder/thumbnail readbacks

There is a problem with readbacks when hiding tabs which
seems to come from the SurfaceLayer being detach from the tree.

I think this was a regression with
https://codereview.chromium.org/1732323002/ which previously
would be resilient to the actual RWHV's layer being detached.

This caused the readback to only complete when you switch back to
a tab and the layer gets reattached sometimes.
Furthermore, it caused tabs to not have placeholders in the cache
at all since TabContentManager has a kMaxReadbacks limit of 1,
so the interrupted readback was preventing other ones also.

The fix is to use the new Surface readback API which
works regardless of the SurfaceLayer's attachment state
and bypasses the UI compositor

BUG=574537
==========

to

==========
Android: Fix some tab placeholder/thumbnail readbacks

There is a problem with readbacks when hiding tabs which
seems to come from the SurfaceLayer being detach from the tree.

I think this was a regression with
https://codereview.chromium.org/1732323002/ which previously
would be resilient to the actual RWHV's layer being detached.

This caused the readback to only complete when you switch back to
a tab and the layer gets reattached sometimes.
Furthermore, it caused tabs to not have placeholders in the cache
at all since TabContentManager has a kMaxReadbacks limit of 1,
so the interrupted readback was preventing other ones also.

The fix is to use the new Surface readback API which
works regardless of the SurfaceLayer's attachment state
and bypasses the UI compositor

BUG=574537
==========

[commit-bot: I haz the power, 2016-07-27 00:00:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-27 00:04:23]

Description was changed from

==========
Android: Fix some tab placeholder/thumbnail readbacks

There is a problem with readbacks when hiding tabs which
seems to come from the SurfaceLayer being detach from the tree.

I think this was a regression with
https://codereview.chromium.org/1732323002/ which previously
would be resilient to the actual RWHV's layer being detached.

This caused the readback to only complete when you switch back to
a tab and the layer gets reattached sometimes.
Furthermore, it caused tabs to not have placeholders in the cache
at all since TabContentManager has a kMaxReadbacks limit of 1,
so the interrupted readback was preventing other ones also.

The fix is to use the new Surface readback API which
works regardless of the SurfaceLayer's attachment state
and bypasses the UI compositor

BUG=574537
==========

to

==========
Android: Fix some tab placeholder/thumbnail readbacks

There is a problem with readbacks when hiding tabs which
seems to come from the SurfaceLayer being detach from the tree.

I think this was a regression with
https://codereview.chromium.org/1732323002/ which previously
would be resilient to the actual RWHV's layer being detached.

This caused the readback to only complete when you switch back to
a tab and the layer gets reattached sometimes.
Furthermore, it caused tabs to not have placeholders in the cache
at all since TabContentManager has a kMaxReadbacks limit of 1,
so the interrupted readback was preventing other ones also.

The fix is to use the new Surface readback API which
works regardless of the SurfaceLayer's attachment state
and bypasses the UI compositor

BUG=574537

Committed: https://crrev.com/3e5517a5b9a2c05bc1300539337236ccd969b2b2
Cr-Commit-Position: refs/heads/master@{#407980}
==========

[commit-bot: I haz the power, 2016-07-27 00:04:25]

Patchset 3 (id:??) landed as
https://crrev.com/3e5517a5b9a2c05bc1300539337236ccd969b2b2
Cr-Commit-Position: refs/heads/master@{#407980}