Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2278823002: Fix getInternalformativ on GL 4.1 or lower. (Closed)

Created:
4 years, 4 months ago by Zhenyao Mo
Modified:
4 years, 3 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix getInternalformativ on GL 4.1 or lower. BUG=633022 TEST=webgl2_conformance R=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3a2fbf7da5f90804ae03f0634248639cf22330ad Cr-Commit-Position: refs/heads/master@{#414488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Zhenyao Mo
piman: PTAL
4 years, 4 months ago (2016-08-25 02:55:58 UTC) #3
piman
lgtm
4 years, 4 months ago (2016-08-25 03:24:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278823002/1
4 years, 3 months ago (2016-08-25 15:44:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 18:42:36 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 18:44:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a2fbf7da5f90804ae03f0634248639cf22330ad
Cr-Commit-Position: refs/heads/master@{#414488}

Powered by Google App Engine
This is Rietveld 408576698