Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2278823002: Fix getInternalformativ on GL 4.1 or lower. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/gpu/gpu_tests/webgl2_conformance_expectations.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 3895c9f7b023467215c13843320cba7d1079154e..a4b4a5019b2e82741605890d849b462eaebe9cff 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -16329,13 +16329,12 @@ error::Error GLES2DecoderImpl::HandleGetInternalformativ(
GLsizei num_values = 0;
std::vector<GLint> samples;
if (gl_version_info().IsLowerThanGL(4, 2)) {
- if (!GLES2Util::IsIntegerFormat(format) &&
- !GLES2Util::IsFloatFormat(format)) {
- // No multisampling for integer formats and float formats.
+ if (!GLES2Util::IsIntegerFormat(format)) {
+ // No multisampling for integer formats.
GLint max_samples = renderbuffer_manager()->max_samples();
while (max_samples > 0) {
samples.push_back(max_samples);
- max_samples = max_samples >> 1;
+ --max_samples;
}
}
switch (pname) {
« no previous file with comments | « content/test/gpu/gpu_tests/webgl2_conformance_expectations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698