Reorder functions in add_to_homescreen_dialog_helper.cc to match order in .h file

Reorder functions in add_to_homescreen_dialog_helper.cc to match order in .h file

This CL also makes the AddToHomescreenDataFetcher::Observer overrides private

BUG=627250
Committed: https://crrev.com/7e341661e7b07653fd25f31996bbe875a5d3fc6f
Cr-Commit-Position: refs/heads/master@{#414226}

[pkotwicz, 2016-08-24 20:39:12]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-08-24 20:40:34]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2016-08-24 20:59:39]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2016-08-24 20:59:40]

Dominick, can you please take a look?

This CL is a subset of https://codereview.chromium.org/2244223002/ The goal of
this CL is to make the diff in https://codereview.chromium.org/2244223002/
smaller

[dominickn, 2016-08-24 22:58:16]

lgtm % nits

https://codereview.chromium.org/2278693002/diff/60001/chrome/browser/android/...
File chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h (right):

https://codereview.chromium.org/2278693002/diff/60001/chrome/browser/android/...
chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h:36: //
Registers JNI hooks.
Nit: I would order the static method above the constructor.

https://codereview.chromium.org/2278693002/diff/60001/chrome/browser/android/...
chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h:48: virtual
~AddToHomescreenDialogHelper();
Just realised that this has a private virtual destructor. Not sure if that makes
sense - it should probably be public and virtual or private and non-virtual.

[pkotwicz, 2016-08-24 23:14:51]

https://codereview.chromium.org/2278693002/diff/60001/chrome/browser/android/...
File chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h (right):

https://codereview.chromium.org/2278693002/diff/60001/chrome/browser/android/...
chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h:36: //
Registers JNI hooks.
On 2016/08/24 22:58:16, dominickn wrote:
> Nit: I would order the static method above the constructor.

Done.

https://codereview.chromium.org/2278693002/diff/60001/chrome/browser/android/...
chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h:48: virtual
~AddToHomescreenDialogHelper();
Making the destructor private seems like a common pattern for C++ code owned by
Java. For instance:
https://cs.chromium.org/chromium/src/chrome/browser/android/recently_closed_t...

[pkotwicz, 2016-08-24 23:15:04]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-08-24 23:15:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2278693002/#ps80001
(title: "Merge branch 'master' into webapk_dialog_detector00")

[commit-bot: I haz the power, 2016-08-24 23:16:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-08-25 00:16:05]

https://codereview.chromium.org/2278693002/diff/60001/chrome/browser/android/...
File chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h (right):

https://codereview.chromium.org/2278693002/diff/60001/chrome/browser/android/...
chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h:48: virtual
~AddToHomescreenDialogHelper();
On 2016/08/24 23:14:50, pkotwicz wrote:
> Making the destructor private seems like a common pattern for C++ code owned
by
> Java. For instance:
>
https://cs.chromium.org/chromium/src/chrome/browser/android/recently_closed_t...

I'm not fussed about the destructor being private - that's appropriate here. I
don't think the destructor should be private and virtual - that doesn't make
sense. :)

[commit-bot: I haz the power, 2016-08-25 00:38:33]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-08-25 00:40:33]

Description was changed from

==========
Reorder functions in add_to_homescreen_dialog_helper.cc to match order in .h
file

This CL also makes the AddToHomescreenDataFetcher::Observer overrides private

BUG=627250
==========

to

==========
Reorder functions in add_to_homescreen_dialog_helper.cc to match order in .h
file

This CL also makes the AddToHomescreenDataFetcher::Observer overrides private

BUG=627250

Committed: https://crrev.com/7e341661e7b07653fd25f31996bbe875a5d3fc6f
Cr-Commit-Position: refs/heads/master@{#414226}
==========

[commit-bot: I haz the power, 2016-08-25 00:40:34]

Patchset 3 (id:??) landed as
https://crrev.com/7e341661e7b07653fd25f31996bbe875a5d3fc6f
Cr-Commit-Position: refs/heads/master@{#414226}